linux-kernel - Re: [PATCH v6 10/12] perf stat: Use affinity for reading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191115183739.GC22747@tassilo.jf.intel.com>
Date:   Fri, 15 Nov 2019 10:37:39 -0800
From:   Andi Kleen <ak@...ux.intel.com>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     Andi Kleen <andi@...stfloor.org>, jolsa@...nel.org,
        acme@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 10/12] perf stat: Use affinity for reading

> > diff --git a/tools/perf/util/evsel.h b/tools/perf/util/evsel.h
> > index ca82a93960cd..c8af4bc23f8f 100644
> > --- a/tools/perf/util/evsel.h
> > +++ b/tools/perf/util/evsel.h
> > @@ -86,6 +86,7 @@ struct evsel {
> >  	struct list_head	config_terms;
> >  	struct bpf_object	*bpf_obj;
> >  	int			bpf_fd;
> > +	int			err;
> 
> I was wondering what would be the best place for this,
> and all the previous variables u added and this one
> are stat specific, so I think this all belongs to
>   
>   (struct perf_stat_evsel*) evsel->stat

I hope to eventually make perf record use affinity too.
Just not in this patchkit. So I'll keep them in the generic
evsel for now.

-Andi