linux-kernel - Re: [PATCH v10 2/2] selftests: add tests for clone3() with *set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 15 Nov 2019 10:39:32 -0800
From:   Andrei Vagin <avagin@...il.com>
To:     Adrian Reber <areber@...hat.com>
Cc:     Christian Brauner <christian.brauner@...ntu.com>,
        Eric Biederman <ebiederm@...ssion.com>,
        Pavel Emelyanov <ovzxemul@...il.com>,
        Jann Horn <jannh@...gle.com>, Oleg Nesterov <oleg@...hat.com>,
        Dmitry Safonov <0x7f454c46@...il.com>,
        Rasmus Villemoes <linux@...musvillemoes.dk>,
        LKML <linux-kernel@...r.kernel.org>,
        Mike Rapoport <rppt@...ux.ibm.com>,
        Radostin Stoyanov <rstoyanov1@...il.com>
Subject: Re: [PATCH v10 2/2] selftests: add tests for clone3() with *set_tid

On Fri, Nov 15, 2019 at 7:14 AM Adrian Reber <areber@...hat.com> wrote:
>
> On Thu, Nov 14, 2019 at 10:34:21AM -0800, Andrei Vagin wrote:
>
> > > +   snprintf(proc_path, sizeof(proc_path), "/proc/%d/status", pid);
> > > +   f = fopen(proc_path, "r");
> > > +   if (f == NULL)
> > > +           ksft_exit_fail_msg(
> > > +                   "%s - Could not open %s\n",
> > > +                   strerror(errno), proc_path);
>
> If the child does not exist anymore, the test will fail here and exit.
>
> Besides this while() I tried to address all your comments in v11. Any
> further comments on the test?

No, I don't have any other comments.

Thanks,
Andrei