linux-kernel - Re: [PATCH 06/12] genirq: Introduce irq_chip_get/set_parent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5dcef6d8.1c69fb81.c72c8.050f@mx.google.com>
Date:   Fri, 15 Nov 2019 11:04:55 -0800
From:   Stephen Boyd <swboyd@...omium.org>
To:     Lina Iyer <ilina@...eaurora.org>, bjorn.andersson@...aro.org,
        linus.walleij@...aro.org, maz@...nel.org
Cc:     evgreen@...omium.org, linux-kernel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, mkshah@...eaurora.org,
        linux-gpio@...r.kernel.org, agross@...nel.org,
        dianders@...omium.org, Lina Iyer <ilina@...eaurora.org>
Subject: Re: [PATCH 06/12] genirq: Introduce irq_chip_get/set_parent_state calls

Quoting Lina Iyer (2019-11-14 10:35:15)
> From: Maulik Shah <mkshah@...eaurora.org>
> 
> On certain QTI chipsets some GPIOs are direct-connect interrupts to the
> GIC to be used as regular interrupt lines. When the GPIOs are not used
> for interrupt generation the interrupt line is disabled. But disabling
> the interrupt at GIC does not prevent the interrupt to be reported as
> pending at GIC_ISPEND. Later, when drivers call enable_irq() on the
> interrupt, an unwanted interrupt occurs.
> 
> Introduce get and set methods for irqchip's parent to clear it's pending
> irq state. This then can be invoked by the GPIO interrupt controller on
> the parents in it hierarchy to clear the interrupt before enabling the
> interrupt.
> 
> Signed-off-by: Maulik Shah <mkshah@...eaurora.org>
> [updated commit text and minor code fixes]
> Signed-off-by: Lina Iyer <ilina@...eaurora.org>
> ---

Reviewed-by: Stephen Boyd <swboyd@...omium.org>