linux-kernel - Re: [PATCH] workqueue: Add RCU annotation for pwq list walk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191115195353.GS4163745@devbig004.ftw2.facebook.com>
Date:   Fri, 15 Nov 2019 11:53:53 -0800
From:   Tejun Heo <tj@...nel.org>
To:     Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Cc:     Joel Fernandes <joel@...lfernandes.org>,
        "Paul E. McKenney" <paulmck@...ux.ibm.com>,
        Lai Jiangshan <jiangshanlai@...il.com>,
        linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] workqueue: Add RCU annotation for pwq list walk

On Fri, Nov 15, 2019 at 07:01:25PM +0100, Sebastian Andrzej Siewior wrote:
> An additional check has been recently added to ensure that a RCU related lock
> is held while the RCU list is iterated.
> The `pwqs' are sometimes iterated without a RCU lock but with the &wq->mutex
> acquired leading to a warning.
> 
> Teach list_for_each_entry_rcu() that the RCU usage is okay if &wq->mutex
> is acquired during the list traversal.
> 
> Fixes: 28875945ba98d ("rcu: Add support for consolidated-RCU reader checking")
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>

Applied to wq/for-5.5.

Thanks.

-- 
tejun