linux-kernel - Re: [PATCH] net: ep93xx_eth: fix mismatch of request_mem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191115.124255.1583855143943561160.davem@davemloft.net>
Date:   Fri, 15 Nov 2019 12:42:55 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     hslester96@...il.com
Cc:     hsweeten@...ionengravers.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: ep93xx_eth: fix mismatch of request_mem_region in
 remove

From: Chuhong Yuan <hslester96@...il.com>
Date: Thu, 14 Nov 2019 23:43:24 +0800

> The driver calls release_resource in remove to match request_mem_region
> in probe, which is incorrect.
> Fix it by using the right one, release_mem_region.
> 
> Signed-off-by: Chuhong Yuan <hslester96@...il.com>

Applied, thanks.

It's a shame that you can't just pass in the thing you got back from
request_mem_region() to free it.  And honestly the only thing that makes
calling release_region() wrong is that release_region() doesn't free up
the region object after unlinking it from the tree.