linux-kernel - RE: [PATCH v3 10/13] usb: gadget: udc: renesas_usb3: create debugfs directory under usb root

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <TYAPR01MB454479F91B948904C213B94CD8700@TYAPR01MB4544.jpnprd01.prod.outlook.com>
Date:   Fri, 15 Nov 2019 05:33:24 +0000
From:   Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
To:     Chunfeng Yun <chunfeng.yun@...iatek.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Felipe Balbi <balbi@...nel.org>
CC:     Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Peter Chen <Peter.Chen@....com>,
        Minas Harutyunyan <hminas@...opsys.com>,
        Cristian Birsan <cristian.birsan@...rochip.com>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Ludovic Desroches <ludovic.desroches@...rochip.com>,
        Kevin Cernekee <cernekee@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "bcm-kernel-feedback-list@...adcom.com" 
        <bcm-kernel-feedback-list@...adcom.com>,
        Daniel Mack <daniel@...que.org>,
        Haojian Zhuang <haojian.zhuang@...il.com>,
        Robert Jarzmik <robert.jarzmik@...e.fr>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>, Bin Liu <b-liu@...com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Stephen Boyd <swboyd@...omium.org>,
        Colin Ian King <colin.king@...onical.com>,
        Biju Das <biju.das@...renesas.com>,
        Fabrizio Castro <fabrizio.castro@...renesas.com>,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        Yangtao Li <tiny.windzz@...il.com>,
        "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>
Subject: RE: [PATCH v3 10/13] usb: gadget: udc: renesas_usb3: create debugfs
 directory under usb root

Hi Chunfeng-san,

> From: Chunfeng Yun, Sent: Thursday, November 14, 2019 7:41 PM
> 
> Now the USB gadget subsystem can use the USB debugfs root directory,
> so move it's directory from the root of the debugfs filesystem into
> the root of usb
> 
> Signed-off-by: Chunfeng Yun <chunfeng.yun@...iatek.com>

Thank you for the patch! When I apply this patch on the Greg's usb.git /
usb-next branch, the following warning happens:

$ patch -p1 < ~/Downloads/v3-10-13-usb-gadget-udc-renesas_usb3-create-debugfs-directory-under-usb-root.patch
patching file drivers/usb/gadget/udc/renesas_usb3.c
Hunk #1 succeeded at 2536 (offset 1 line).

I'm not sure we should fix it strictly though, this patch seems good to me. So,

Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>

And, I tested this patch on my environment and confirmed that
the debug file moved from /sys/kernel/debug to /sys/kernel/debug/usb. So,

Tested-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>

Best regards,
Yoshihiro Shimoda


> ---
> v3: no changes
> 
> v2:
>   1. abandon new API usb_debugfs_create_dir(), and use usb_debug_root
> ---
>  drivers/usb/gadget/udc/renesas_usb3.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/gadget/udc/renesas_usb3.c b/drivers/usb/gadget/udc/renesas_usb3.c
> index e098f16c01cb..4dde69e7f6b1 100644
> --- a/drivers/usb/gadget/udc/renesas_usb3.c
> +++ b/drivers/usb/gadget/udc/renesas_usb3.c
> @@ -2535,7 +2535,7 @@ static const struct file_operations renesas_usb3_b_device_fops = {
>  static void renesas_usb3_debugfs_init(struct renesas_usb3 *usb3,
>  				      struct device *dev)
>  {
> -	usb3->dentry = debugfs_create_dir(dev_name(dev), NULL);
> +	usb3->dentry = debugfs_create_dir(dev_name(dev), usb_debug_root);
> 
>  	debugfs_create_file("b_device", 0644, usb3->dentry, usb3,
>  			    &renesas_usb3_b_device_fops);
> --
> 2.23.0