lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 14 Nov 2019 19:27:09 -0500 From: "Theodore Y. Ts'o" <tytso@....edu> To: Jan Kara <jack@...e.cz> Cc: Konstantin Khlebnikov <khlebnikov@...dex-team.ru>, Ritesh Harjani <riteshh@...ux.ibm.com>, Andreas Dilger <adilger.kernel@...ger.ca>, linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org, Dmitry Monakhov <dmtrmonakhov@...dex-team.ru>, Eric Whitney <enwlinux@...il.com> Subject: Re: [PATCH] ext4: deaccount delayed allocations at freeing inode in ext4_evict_inode() > From ee27836b579d3bf750d45cd7081d3433ea6fedd5 Mon Sep 17 00:00:00 2001 > From: Jan Kara <jack@...e.cz> > Date: Fri, 8 Nov 2019 12:45:11 +0100 > Subject: [PATCH] ext4: Fix leak of quota reservations > > Commit 8fcc3a580651 ("ext4: rework reserved cluster accounting when > invalidating pages") moved freeing of delayed allocation reservations > from dirty page invalidation time to time when we evict corresponding > status extent from extent status tree. For inodes which don't have any > blocks allocated this may actually happen only in ext4_clear_blocks() > which is after we've dropped references to quota structures from the > inode. Thus reservation of quota leaked. Fix the problem by clearing > quota information from the inode only after evicting extent status tree > in ext4_clear_inode(). > > Reported-by: Konstantin Khlebnikov <khlebnikov@...dex-team.ru> > Fixes: 8fcc3a580651 ("ext4: rework reserved cluster accounting when invalidating pages") > Signed-off-by: Jan Kara <jack@...e.cz> OK, I've applied this patch. - Ted
Powered by blists - more mailing lists