linux-kernel - Re: [PATCH] hwmon: (dell-smm-hwmon) Disable BIOS fan control on SET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201911151513.11JI2bJS%lkp@intel.com>
Date:   Fri, 15 Nov 2019 15:12:25 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Giovanni Mascellani <gio@...ian.org>
Cc:     kbuild-all@...ts.01.org,
        Pali Rohár <pali.rohar@...il.com>,
        Jean Delvare <jdelvare@...e.com>,
        Guenter Roeck <linux@...ck-us.net>,
        linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org,
        Giovanni Mascellani <gio@...ian.org>
Subject: Re: [PATCH] hwmon: (dell-smm-hwmon) Disable BIOS fan control on
 SET_FAN

Hi Giovanni,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on hwmon/hwmon-next]
[also build test ERROR on v5.4-rc7 next-20191114]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Giovanni-Mascellani/hwmon-dell-smm-hwmon-Disable-BIOS-fan-control-on-SET_FAN/20191115-052315
base:   https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
config: i386-randconfig-c001-20191115 (attached as .config)
compiler: gcc-7 (Debian 7.4.0-14) 7.4.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/hwmon/dell-smm-hwmon.c: In function 'i8k_exit':
>> drivers/hwmon/dell-smm-hwmon.c:1305:7: error: implicit declaration of function 'i8k_enable_bios' [-Werror=implicit-function-declaration]
      if (i8k_enable_bios())
          ^~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/i8k_enable_bios +1305 drivers/hwmon/dell-smm-hwmon.c

  1297	
  1298	static void __exit i8k_exit(void)
  1299	{
  1300		hwmon_device_unregister(i8k_hwmon_dev);
  1301		i8k_exit_procfs();
  1302	
  1303		if (bios_disabled) {
  1304			pr_warn("re-enabling BIOS fan control\n");
> 1305			if (i8k_enable_bios())
  1306				pr_warn("could not re-enable BIOS fan control\n");
  1307		}
  1308	}
  1309	

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (30155 bytes)