linux-kernel - Re: [RFC PATCH] x86/acpi: Drop duplicate BOOT table initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 15 Nov 2019 10:09:06 +0100
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Shiyang Ruan <ruansy.fnst@...fujitsu.com>
Cc:     "the arch/x86 maintainers" <x86@...nel.org>,
        Linux PM <linux-pm@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Len Brown <len.brown@...el.com>, Pavel Machek <pavel@....cz>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        "H. Peter Anvin" <hpa@...or.com>,
        Cao jin <caoj.fnst@...fujitsu.com>
Subject: Re: [RFC PATCH] x86/acpi: Drop duplicate BOOT table initialization

On Fri, Nov 15, 2019 at 6:06 AM Shiyang Ruan <ruansy.fnst@...fujitsu.com> wrote:
>
> From: Cao jin <caoj.fnst@...fujitsu.com>
>
> ACPI BOOT table is initialized in both acpi_boot_table_init &
> acpi_boot_init of setup_arch, but its usage is quite late at the end of
> start_kernel. It should be safe to drop one of them. Since it is less
> related with table init, drop it from there.
>
> Signed-off-by: Cao jin <caoj.fnst@...fujitsu.com>

Please resend with a CC to linux-acpi@...r.kernel.org

> ---
>  arch/x86/kernel/acpi/boot.c | 2 --
>  1 file changed, 2 deletions(-)
>
> It existed since git repo is built, so it might has its reason? The
> patch is not tested since I don't have BOOT table in my firmware.
>
> diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c
> index 04205ce127a1..ca1c15bb0b48 100644
> --- a/arch/x86/kernel/acpi/boot.c
> +++ b/arch/x86/kernel/acpi/boot.c
> @@ -1558,8 +1558,6 @@ void __init acpi_boot_table_init(void)
>                 return;
>         }
>
> -       acpi_table_parse(ACPI_SIG_BOOT, acpi_parse_sbf);
> -
>         /*
>          * blacklist may disable ACPI entirely
>          */
> --
> 2.21.0
>
>
>