linux-kernel - Re: [PATCH v1 2/2] mfd: syscon: Switch to use devm_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191115102051.GP32742@smile.fi.intel.com>
Date:   Fri, 15 Nov 2019 12:20:51 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Lee Jones <lee.jones@...aro.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 2/2] mfd: syscon: Switch to use devm_ioremap_resource()

On Fri, Nov 15, 2019 at 10:12:57AM +0100, Arnd Bergmann wrote:
> On Fri, Nov 15, 2019 at 9:49 AM Andy Shevchenko
> <andriy.shevchenko@...ux.intel.com> wrote:
> >
> > Instead of checking resource pointer for being NULL and
> > report some not very standard error codes in this case,
> > switch to devm_ioremap_resource() API.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> 
> IIRC there are some slightly odd uses of syscon that rely on on us not calling
> devm_request_mem_region here, which is implied by devm_ioremap_resource()
> but not devm_ioremap().

Ah, I see.

> A patch to add a comment about this might be helpful though.

I think the comment won't help if there are overlapping regions are in use.
Probably no need to apply this for now.

-- 
With Best Regards,
Andy Shevchenko