linux-kernel - Re: [PATCH v2 06/16] x86/cpu: Clear VMX feature flag if VMX is not fully enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191115103434.GH18929@zn.tnic>
Date:   Fri, 15 Nov 2019 11:34:34 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     Paolo Bonzini <pbonzini@...hat.com>,
        Sean Christopherson <sean.j.christopherson@...el.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, x86@...nel.org,
        "H. Peter Anvin" <hpa@...or.com>, linux-kernel@...r.kernel.org,
        Radim Krčmář <rkrcmar@...hat.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>, kvm@...r.kernel.org
Subject: Re: [PATCH v2 06/16] x86/cpu: Clear VMX feature flag if VMX is not
 fully enabled

On Fri, Nov 15, 2019 at 11:05:24AM +0100, Paolo Bonzini wrote:
> On 14/11/19 19:32, Sean Christopherson wrote:
> >>> +			pr_err_once("x86/cpu: VMX disabled, IA32_FEATURE_CONTROL MSR unsupported\n");
> > 
> > My thought for having the print was to alert the user that something is
> > royally borked with their system.  There's nothing the user can do to fix
> > it per se, but it does indicate that either their hardware or the VMM
> > hosting their virtual machine is broken.  So maybe be more explicit about
> > it being a likely hardware/VMM issue?
> 
> Yes, good idea.

Yah, let's make sure it has some merit for users and doesn't make them
only shrug and ignore it.

Btw, Sean, are you sending a new version of this ontop of latest
tip/master or linux-next or so? I'd like to look at the rest of the bits
in detail.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette