linux-kernel - Re: [PATCH net-next v2] ath10k: fix RX of frames with broken FCS in monitor mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87a78xwdxe.fsf@codeaurora.org>
Date:   Fri, 15 Nov 2019 13:56:45 +0200
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Linus Lüssing <linus.luessing@...3.blue>
Cc:     ath10k@...ts.infradead.org,
        "David S . Miller" <davem@...emloft.net>,
        Ben Greear <greearb@...delatech.com>,
        Simon Wunderlich <sw@...onwunderlich.de>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Linus Lüssing <ll@...onwunderlich.de>
Subject: Re: [PATCH net-next v2] ath10k: fix RX of frames with broken FCS in monitor mode

Linus Lüssing <linus.luessing@...3.blue> writes:

> From: Linus Lüssing <ll@...onwunderlich.de>
>
> So far, frames were forwarded regardless of the FCS correctness leading
> to userspace applications listening on the monitor mode interface to
> receive potentially broken frames, even with the "fcsfail" flag unset.
>
> By default, with the "fcsfail" flag of a monitor mode interface
> unset, frames with FCS errors should be dropped. With this patch, the
> fcsfail flag is taken into account correctly.
>
> Cc: Simon Wunderlich <sw@...onwunderlich.de>
> Signed-off-by: Linus Lüssing <ll@...onwunderlich.de>

ath10k patches go ath-next branch, not net-next. So to avoid confusion
please don't mark ath10k patches as "net-next", please.

> ---
> This was tested on an Open Mesh A41 device, featuring a QCA4019. And
> with this firmware:
>
> https://www.candelatech.com/downloads/ath10k-4019-10-4b/firmware-5-ct-full-community-12.bin-lede.011

I'll add this testing information to the commit log. (No need to resend
just because of commit log changes)

> But from looking at the code it seems that the vanilla ath10k has the
> same issue, therefore submitting it here.

So this should work with the Qualcomm firmware as well, right?

-- 
Kalle Valo