linux-kernel - Re: [PATCH v4 2/4] iio: adc: ad7091r5: Add scale and external VREF support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191115130359.GE19101@kadam.lan>
Date:   Fri, 15 Nov 2019 16:03:59 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Beniamin Bia <beniamin.bia@...log.com>
Cc:     jic23@...nel.org, devel@...verdev.osuosl.org, mark.rutland@....com,
        lars@...afoo.de, biabeniamin@...look.com,
        Michael.Hennerich@...log.com, devicetree@...r.kernel.org,
        linux-iio@...r.kernel.org, gregkh@...uxfoundation.org,
        linux-kernel@...r.kernel.org, robh+dt@...nel.org,
        pmeerw@...erw.net, knaack.h@....de,
        Paul Cercueil <paul.cercueil@...log.com>
Subject: Re: [PATCH v4 2/4] iio: adc: ad7091r5: Add scale and external VREF
 support

On Fri, Nov 15, 2019 at 02:23:14PM +0200, Beniamin Bia wrote:
> @@ -216,6 +240,21 @@ int ad7091r_probe(struct device *dev, const char *name,
>  			return ret;
>  	}
>  
> +	st->vref = devm_regulator_get_optional(dev, "vref");
> +	if (IS_ERR(st->vref)) {
> +		if (PTR_ERR(st->vref) == EPROBE_DEFER)
                                      ^^^^^^^^^^^^^^^
Missing - on EPROBE_DEFER.

> +			return -EPROBE_DEFER;
> +
> +		st->vref = NULL;
> +	} else {
> +		ret = regulator_enable(st->vref);
> +		if (ret)
> +			return ret;
> +		ret = devm_add_action_or_reset(dev, ad7091r_remove, st);
> +		if (ret)
> +			return ret;
> +		}

Curly brace is indented an extra tab.

regards,
dan carpenter