linux-kernel - Re: [PATCH v1 2/2] perf report: Jump to symbol source view from total cycles view

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191115133438.GA25491@krava>
Date:   Fri, 15 Nov 2019 14:34:38 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     Jin Yao <yao.jin@...ux.intel.com>
Cc:     acme@...nel.org, jolsa@...nel.org, peterz@...radead.org,
        mingo@...hat.com, alexander.shishkin@...ux.intel.com,
        Linux-kernel@...r.kernel.org, ak@...ux.intel.com,
        kan.liang@...el.com, yao.jin@...el.com
Subject: Re: [PATCH v1 2/2] perf report: Jump to symbol source view from
 total cycles view

On Wed, Nov 13, 2019 at 08:48:52AM +0800, Jin Yao wrote:
> This patch supports jumping from tui total cycles view to symbol
> source view.
> 
> For example,
> 
> perf record -b ./div
> perf report --total-cycles
> 
> In total cycles view, we can select one entry and press 'a' or
> press ENTER key to jump to symbol source view.
> 
> Signed-off-by: Jin Yao <yao.jin@...ux.intel.com>
> ---
>  tools/perf/builtin-report.c    |  9 ++++++---
>  tools/perf/ui/browsers/hists.c | 25 +++++++++++++++++++++++--
>  tools/perf/util/block-info.c   |  6 ++++--
>  tools/perf/util/block-info.h   |  3 ++-
>  tools/perf/util/hist.h         |  7 +++++--
>  5 files changed, 40 insertions(+), 10 deletions(-)
> 
> diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
> index 1e81985b7d56..ceebea4013ca 100644
> --- a/tools/perf/builtin-report.c
> +++ b/tools/perf/builtin-report.c
> @@ -493,7 +493,9 @@ static int perf_evlist__tui_block_hists_browse(struct evlist *evlist,
>  
>  	evlist__for_each_entry(evlist, pos) {
>  		ret = report__browse_block_hists(&rep->block_reports[i++].hist,
> -						 rep->min_percent, pos);
> +						 rep->min_percent, pos,
> +						 &rep->session->header.env,
> +						 &rep->annotation_opts);
>  		if (ret != 0)
>  			return ret;
>  	}
> @@ -525,7 +527,8 @@ static int perf_evlist__tty_browse_hists(struct evlist *evlist,
>  
>  		if (rep->total_cycles_mode) {
>  			report__browse_block_hists(&rep->block_reports[i++].hist,
> -						   rep->min_percent, pos);
> +						   rep->min_percent, pos,
> +						   NULL, NULL);
>  			continue;
>  		}
>  
> @@ -1418,7 +1421,7 @@ int cmd_report(int argc, const char **argv)
>  		if (sort__mode != SORT_MODE__BRANCH)
>  			report.total_cycles_mode = false;
>  		else
> -			sort_order = "sym";
> +			sort_order = NULL;

hum, how is this related to this change?

jirka