linux-kernel - Re: [PATCH v2] ext4: bio_alloc with __GFP_DIRECT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191115031953.GA30252@mit.edu>
Date:   Thu, 14 Nov 2019 22:19:53 -0500
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Chao Yu <yuchao0@...wei.com>
Cc:     Gao Xiang <gaoxiang25@...wei.com>,
        Andreas Dilger <adilger.kernel@...ger.ca>,
        linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org,
        Ritesh Harjani <riteshh@...ux.ibm.com>
Subject: Re: [PATCH v2] ext4: bio_alloc with __GFP_DIRECT_RECLAIM never fails

On Thu, Oct 31, 2019 at 05:29:58PM +0800, Chao Yu wrote:
> On 2019/10/31 17:23, Gao Xiang wrote:
> > Similar to [1] [2], bio_alloc with __GFP_DIRECT_RECLAIM flags
> > guarantees bio allocation under some given restrictions, as
> > stated in block/bio.c and fs/direct-io.c So here it's ok to
> > not check for NULL value from bio_alloc().
> > 
> > [1] https://lore.kernel.org/r/20191030035518.65477-1-gaoxiang25@huawei.com
> > [2] https://lore.kernel.org/r/20190830162812.GA10694@infradead.org
> > Cc: Theodore Ts'o <tytso@....edu>
> > Cc: Andreas Dilger <adilger.kernel@...ger.ca>
> > Cc: Ritesh Harjani <riteshh@...ux.ibm.com>
> > Cc: Chao Yu <yuchao0@...wei.com>
> > Signed-off-by: Gao Xiang <gaoxiang25@...wei.com>
> 
> Reviewed-by: Chao Yu <yuchao0@...wei.com>

Thanks, applied.

					- Ted