linux-kernel - Re: [PATCH v11 1/2] fork: extend clone3() to support setting a PID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fada5995-7fcc-7ca8-0933-4d0f52deef6e@gmail.com>
Date:   Fri, 15 Nov 2019 16:54:06 +0000
From:   Dmitry Safonov <0x7f454c46@...il.com>
To:     Adrian Reber <areber@...hat.com>,
        Christian Brauner <christian.brauner@...ntu.com>,
        Eric Biederman <ebiederm@...ssion.com>,
        Pavel Emelyanov <ovzxemul@...il.com>,
        Jann Horn <jannh@...gle.com>, Oleg Nesterov <oleg@...hat.com>,
        Andrei Vagin <avagin@...il.com>,
        Rasmus Villemoes <linux@...musvillemoes.dk>
Cc:     linux-kernel@...r.kernel.org, Mike Rapoport <rppt@...ux.ibm.com>,
        Radostin Stoyanov <rstoyanov1@...il.com>
Subject: Re: [PATCH v11 1/2] fork: extend clone3() to support setting a PID

On 11/15/19 12:36 PM, Adrian Reber wrote:
[..]
> Signed-off-by: Adrian Reber <areber@...hat.com>
> Reviewed-by: Christian Brauner <christian.brauner@...ntu.com>

Reviewed-by: Dmitry Safonov <0x7f454c46@...il.com>

[though, I have 2 minor nits below]

[..]
> + * @set_tid:      Pointer to an array of type *pid_t. The size
> + *                of the array is defined using @set_tid_size.
> + *                This array is used select PIDs/TIDs for newly

/is used select/is used to select/s


[..]
> +	size_t set_tid_size;
> +	__aligned_u64 set_tid_size;

[..]
> +		.set_tid_size	= args.set_tid_size,

Is sizeof(size_t) == 32 on native 32-bit platforms?
Maybe `args.set_tid_size` should be checked?

Thanks,
          Dmitry