linux-kernel - Re: [PATCH v2] sched/uclamp: Fix overzealous type replacement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKfTPtCvt7BZ8g2sC3j=uoN-8nXfwRDGaO06xtHN0O+d8u5MQQ@mail.gmail.com>
Date:   Fri, 15 Nov 2019 18:34:19 +0100
From:   Vincent Guittot <vincent.guittot@...aro.org>
To:     Valentin Schneider <valentin.schneider@....com>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Dietmar Eggemann <Dietmar.Eggemann@....com>,
        Tejun Heo <tj@...nel.org>,
        Patrick Bellasi <patrick.bellasi@...bug.net>,
        Suren Baghdasaryan <surenb@...gle.com>,
        Quentin Perret <qperret@...gle.com>,
        Qais Yousef <qais.yousef@....com>
Subject: Re: [PATCH v2] sched/uclamp: Fix overzealous type replacement

On Fri, 15 Nov 2019 at 18:10, Valentin Schneider
<valentin.schneider@....com> wrote:
>
> On 15/11/2019 14:29, Valentin Schneider wrote:
> > On 15/11/2019 14:07, Vincent Guittot wrote:
> >>> -static inline enum uclamp_id uclamp_none(enum uclamp_id clamp_id)
> >>> +static inline unsigned int uclamp_none(enum uclamp_id clamp_id)
> >>
> >> Out of curiosity why uclamp decided to use unsigned int to manipulate
> >> utilization instead of unsigned long which is the type of util_avg ?
> >>
> >
> > I didn't stare at the discussion much, but I think it stems from the
> > design choices behind struct uclamp_se: everything is crammed in an unsigned
> > int bitfield. Let me see if I can find some relevant mails.
> >
>
> So I think a relevant mail is:
>
> https://lore.kernel.org/lkml/20180912174236.GB24106@hirez.programming.kicks-ass.net/
>
> Other than that, the uclamp_se.value field was 'int' in v1 and has been
> 'unsigned int' for all following versions. uclamp_bucket.value is a bitfield
> of an 'unsigned long' just because we want more headroom for the tasks count,
> AFAICT.

Thanks for the pointer and deep diving in the email threads