linux-kernel - Re: [PATCH v4 01/17] mfd: cros_ec: Add sensor_count and make check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191116114923.39e9ce3c@archlinux>
Date:   Sat, 16 Nov 2019 11:49:23 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     Enric Balletbo Serra <eballetbo@...il.com>,
        Gwendal Grignou <gwendal@...omium.org>,
        Brian Norris <briannorris@...omium.org>,
        Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Benson Leung <bleung@...omium.org>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Doug Anderson <dianders@...omium.org>,
        Guenter Roeck <groeck@...omium.org>,
        Fabien Lahoudere <fabien.lahoudere@...labora.com>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        linux-iio <linux-iio@...r.kernel.org>
Subject: Re: [PATCH v4 01/17] mfd: cros_ec: Add sensor_count and make
 check_features public

On Mon, 11 Nov 2019 11:44:23 +0000
Lee Jones <lee.jones@...aro.org> wrote:

> On Fri, 08 Nov 2019, Enric Balletbo Serra wrote:
> 
> > Missatge de Gwendal Grignou <gwendal@...omium.org> del dia dt., 5 de
> > nov. 2019 a les 23:28:  
> > >
> > > Add a new function to return the number of MEMS sensors available in a
> > > ChromeOS Embedded Controller.
> > > It uses MOTIONSENSE_CMD_DUMP if available or a specific memory map ACPI
> > > registers to find out.
> > >
> > > Also, make check_features public as it can be useful for other drivers
> > > to know what the Embedded Controller supports.
> > >
> > > Signed-off-by: Gwendal Grignou <gwendal@...omium.org>  
> > 
> > Version 3 was acked and I think we can maintain his ack, so:
> > 
> > Acked-for-MFD-by: Lee Jones <lee.jones@...aro.org>
> > 
> > Also,
> > 
> > Acked-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>
> > 
> > Lee, how you would like to handle this? I think will be safe for
> > patches 1/2/3 go through the platform-chrome tree without an immutable
> > branch. Patch 3 thought still needs and Ack from you if is fine.  
> 
> Please take the entire set, converting:
> 
>   s/Acked-for-MFD-by/Acked-by/
> 
> ... and send me a pull-request to an immutable branch.
> 

Agreed.  Please do an immutable branch for the whole series v5 if everyone
else is happy with the changes in V5. (I think it was mostly my
comments on v4 so fingers crossed :)

I'll pull it if / when some follow up changes touch the resulting code
on the IIO side. Gwendall, if you can highlight if that occurs that
would be great as well!

Thanks,

Jonathan