linux-kernel - Re: [PATCH 0/2] usb: override hub device bInterval with device node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1911171043060.7716-100000@netrider.rowland.org>
Date:   Sun, 17 Nov 2019 10:46:19 -0500 (EST)
From:   Alan Stern <stern@...land.harvard.edu>
To:     Ikjoon Jang <ikjn@...omium.org>
cc:     linux-usb@...r.kernel.org, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Suwan Kim <suwan.kim027@...il.com>,
        "Gustavo A . R . Silva" <gustavo@...eddedor.com>,
        Johan Hovold <johan@...nel.org>,
        Nicolas Boitchat <drinkcat@...omium.org>
Subject: Re: [PATCH 0/2] usb: override hub device bInterval with device node

On Sun, 17 Nov 2019, Ikjoon Jang wrote:

> This patchset enables hard wired hub device to use different bInterval
> from its descriptor when the hub has a combined device node.
> 
> When we know the specific hard wired hub supports changing its polling
> interval, we can adjust hub's interval to reduce the time of waking up
> from autosuspend or connect detection of HIDs.

In fact, _all_ hubs support changing the polling interval.  The value 
given in the USB spec is just an upper limit; any smaller value is 
equally acceptable.

So why are you doing this only for hard-wired hubs?  Why not for all 
hubs?

And is 250 ms really too long to wait for remote wakeup or connect 
detection?  What's the real motivation behind this change?

Alan Stern