linux-kernel - Re: [PATCH] clk: qcom: mmcc8974: move gfx3d_clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20191117012737.CED5B20730@mail.kernel.org>
Date:   Sat, 16 Nov 2019 17:27:36 -0800
From:   Stephen Boyd <sboyd@...nel.org>
To:     Brian Masney <masneyb@...tation.org>
Cc:     mturquette@...libre.com, agross@...nel.org,
        linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org, bjorn.andersson@...aro.org,
        jonathan@...ek.ca
Subject: Re: [PATCH] clk: qcom: mmcc8974: move gfx3d_clk_src from the mmcc to rpm

Quoting Brian Masney (2019-11-16 10:54:57)
> > diff --git a/drivers/clk/qcom/mmcc-msm8974.c b/drivers/clk/qcom/mmcc-msm8974.c
> > index bcb0a397ef91..015426262d08 100644
> > --- a/drivers/clk/qcom/mmcc-msm8974.c
> > +++ b/drivers/clk/qcom/mmcc-msm8974.c
> > @@ -2411,7 +2399,6 @@ static struct clk_regmap *mmcc_msm8974_clocks[] = {
> >       [VFE0_CLK_SRC] = &vfe0_clk_src.clkr,
> >       [VFE1_CLK_SRC] = &vfe1_clk_src.clkr,
> >       [MDP_CLK_SRC] = &mdp_clk_src.clkr,
> > -     [GFX3D_CLK_SRC] = &gfx3d_clk_src.clkr,
> >       [JPEG0_CLK_SRC] = &jpeg0_clk_src.clkr,
> >       [JPEG1_CLK_SRC] = &jpeg1_clk_src.clkr,
> >       [JPEG2_CLK_SRC] = &jpeg2_clk_src.clkr,
> 
> I just realized that I also need to remove the GFX3D_CLK_SRC #define
> from include/dt-bindings/clock/qcom,mmcc-msm8974.h. I'll send out a v2
> tomorrow evening.
> 

Please don't change the binding. In reality the define will never be
used but also in reality the clk exists, so it's fine to leave it in the
binding.