linux-kernel - Re: [PATCH v2] mm: get rid of odd jump labels in find_mergeable_anon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <ed7a8b5fb71d4ff4b7b515f402aa265a@huawei.com>
Date:   Mon, 18 Nov 2019 06:24:42 +0000
From:   linmiaohe <linmiaohe@...wei.com>
To:     John Hubbard <jhubbard@...dia.com>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "richardw.yang@...ux.intel.com" <richardw.yang@...ux.intel.com>,
        "sfr@...b.auug.org.au" <sfr@...b.auug.org.au>,
        "rppt@...ux.ibm.com" <rppt@...ux.ibm.com>,
        "jannh@...gle.com" <jannh@...gle.com>,
        "steve.capper@....com" <steve.capper@....com>,
        "catalin.marinas@....com" <catalin.marinas@....com>,
        "aarcange@...hat.com" <aarcange@...hat.com>,
        "walken@...gle.com" <walken@...gle.com>,
        "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
        "tiny.windzz@...il.com" <tiny.windzz@...il.com>,
        "david@...hat.com" <david@...hat.com>
CC:     "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] mm: get rid of odd jump labels in
 find_mergeable_anon_vma()

John Hubbard wrote:
> On 11/17/19 7:22 PM, linmiaohe wrote:
> > From: Miaohe Lin <linmiaohe@...wei.com>
> > 
> > The jump labels try_prev and none are not really needed in 
> > find_mergeable_anon_vma(), eliminate them to improve readability.
> > -v2:
> > 	Fix commit descriptions and further simplify the code
> > 	as suggested by David Hildenbrand and John Hubbard.
>
> Admin point: the above three lines will end up in the commit log, which is probably not what you intended. If, instead, you put them below the "---" line, then they will act as comments about the patch, and won't show up in the commit log.
>
>
Thanks for your remind. I'am sorry for this mistake. I'll fix this. Many thanks.