linux-kernel - Re: [PATCH v4 15/16] leds: Add common LED binding parsing support to LED class/core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 18 Nov 2019 06:34:12 +0000
From:   "Vaittinen, Matti" <Matti.Vaittinen@...rohmeurope.com>
To:     "dan.carpenter@...cle.com" <dan.carpenter@...cle.com>,
        "kbuild@...ts.01.org" <kbuild@...ts.01.org>
CC:     "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "mchehab+samsung@...nel.org" <mchehab+samsung@...nel.org>,
        "sboyd@...nel.org" <sboyd@...nel.org>,
        "linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>,
        "phil.edworthy@...esas.com" <phil.edworthy@...esas.com>,
        "hkallweit1@...il.com" <hkallweit1@...il.com>,
        "m.szyprowski@...sung.com" <m.szyprowski@...sung.com>,
        "mturquette@...libre.com" <mturquette@...libre.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "corbet@....net" <corbet@....net>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "lee.jones@...aro.org" <lee.jones@...aro.org>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "pavel@....cz" <pavel@....cz>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "dmurphy@...com" <dmurphy@...com>,
        "jeffrey.t.kirsher@...el.com" <jeffrey.t.kirsher@...el.com>,
        "a.zummo@...ertech.it" <a.zummo@...ertech.it>,
        "hofrat@...dl.org" <hofrat@...dl.org>,
        "alexandre.belloni@...tlin.com" <alexandre.belloni@...tlin.com>,
        "mazziesaccount@...il.com" <mazziesaccount@...il.com>,
        "linux-rtc@...r.kernel.org" <linux-rtc@...r.kernel.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "kbuild-all@...ts.01.org" <kbuild-all@...ts.01.org>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "jacek.anaszewski@...il.com" <jacek.anaszewski@...il.com>,
        "wsa+renesas@...g-engineering.com" <wsa+renesas@...g-engineering.com>,
        "linux-leds@...r.kernel.org" <linux-leds@...r.kernel.org>,
        "bgolaszewski@...libre.com" <bgolaszewski@...libre.com>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>
Subject: Re: [PATCH v4 15/16] leds: Add common LED binding parsing support
 to LED class/core

Hello All,

On Mon, 2019-11-18 at 08:59 +0300, Dan Carpenter wrote:
> Hi Matti,
> 
> [auto build test WARNING on 31f4f5b495a62c9a8b15b1c3581acd5efeb9af8c]
> 
> url:    
> https://github.com/0day-ci/linux/commits/Matti-Vaittinen/Support-ROHM-BD71828-PMIC/20191117-030515
> base:    31f4f5b495a62c9a8b15b1c3581acd5efeb9af8c
> 
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@...el.com>
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> 
> smatch warnings:
> drivers/leds/led-core.c:400 fw_is_match() error: uninitialized symbol
> 'ret'.
> drivers/leds/led-core.c:465 led_find_fwnode() error: double free of
> 'val'

Ouch. The free is clearly a leftover from original code where the
"is_match" was not it's own function. Sorry folks. I'll fix both issues
and send new version.

By the way, I'd appreciate if someone else would also check the
reference-counting for fwnodes - is pumping up the refcount in
led_find_fwnode Ok? My idea is that when-ever the led_find_fwnode
returns an fwnode, the LED class needs to decrease refcount when LED is
unregistered. No matter if fwnode was from device, given by LED driver
or found by the LED class.

Br,
	Matti Vaittinen