linux-kernel - [PATCH v2] gpu: ipu-v3: prg: add missed operations in remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20191118080914.30691-1-hslester96@gmail.com>
Date:   Mon, 18 Nov 2019 16:09:14 +0800
From:   Chuhong Yuan <hslester96@...il.com>
To:     unlisted-recipients:; (no To-header on input)
Cc:     Philipp Zabel <p.zabel@...gutronix.de>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        Chuhong Yuan <hslester96@...il.com>
Subject: [PATCH v2] gpu: ipu-v3: prg: add missed operations in remove

This driver forgets to call pm_runtime_disable and clk_disable_unprepare
in remove.
Add the calls to fix it.

Signed-off-by: Chuhong Yuan <hslester96@...il.com>
---
Changes in v2:
  - Add the missed pm_runtime_disable.

 drivers/gpu/ipu-v3/ipu-prg.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/ipu-v3/ipu-prg.c b/drivers/gpu/ipu-v3/ipu-prg.c
index 196797c1b4b3..897da605da55 100644
--- a/drivers/gpu/ipu-v3/ipu-prg.c
+++ b/drivers/gpu/ipu-v3/ipu-prg.c
@@ -430,6 +430,9 @@ static int ipu_prg_remove(struct platform_device *pdev)
 	list_del(&prg->list);
 	mutex_unlock(&ipu_prg_list_mutex);
 
+	pm_runtime_disable(&pdev->dev);
+	clk_disable_unprepare(prg->clk_axi);
+	clk_disable_unprepare(prg->clk_ipg);
 	return 0;
 }
 
-- 
2.24.0