linux-kernel - RE: [PATCH v2] drm/amd/powerplay: return errno code to caller when error occur

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MN2PR12MB3344BBBA7F72F9625D71329EE44D0@MN2PR12MB3344.namprd12.prod.outlook.com>
Date:   Mon, 18 Nov 2019 08:15:38 +0000
From:   "Quan, Evan" <Evan.Quan@....com>
To:     Chen Wandun <chenwandun@...wei.com>,
        "Deucher, Alexander" <Alexander.Deucher@....com>,
        "amd-gfx@...ts.freedesktop.org" <amd-gfx@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>
Subject: RE: [PATCH v2] drm/amd/powerplay: return errno code to caller when
 error occur

Reviewed-by: Evan Quan <evan.quan@....com>

> -----Original Message-----
> From: Chen Wandun <chenwandun@...wei.com>
> Sent: Monday, November 18, 2019 4:04 PM
> To: Quan, Evan <Evan.Quan@....com>; Deucher, Alexander
> <Alexander.Deucher@....com>; amd-gfx@...ts.freedesktop.org; linux-
> kernel@...r.kernel.org; dri-devel@...ts.freedesktop.org
> Cc: chenwandun@...wei.com
> Subject: [PATCH v2] drm/amd/powerplay: return errno code to caller when
> error occur
> 
> return errno code to caller when error occur, and meanwhile remove gcc '-
> Wunused-but-set-variable' warning.
> 
> drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/vegam_smumgr.c: In
> function vegam_populate_smc_boot_level:
> drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/vegam_smumgr.c:1364:
> 6: warning: variable result set but not used [-Wunused-but-set-variable]
> 
> Signed-off-by: Chen Wandun <chenwandun@...wei.com>
> ---
>  drivers/gpu/drm/amd/powerplay/smumgr/vegam_smumgr.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/vegam_smumgr.c
> b/drivers/gpu/drm/amd/powerplay/smumgr/vegam_smumgr.c
> index 2068eb0..50896e9 100644
> --- a/drivers/gpu/drm/amd/powerplay/smumgr/vegam_smumgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/smumgr/vegam_smumgr.c
> @@ -1371,11 +1371,16 @@ static int vegam_populate_smc_boot_level(struct
> pp_hwmgr *hwmgr,
>  	result = phm_find_boot_level(&(data->dpm_table.sclk_table),
>  			data->vbios_boot_state.sclk_bootup_value,
>  			(uint32_t *)&(table->GraphicsBootLevel));
> +	if (result)
> +		return result;
> 
>  	result = phm_find_boot_level(&(data->dpm_table.mclk_table),
>  			data->vbios_boot_state.mclk_bootup_value,
>  			(uint32_t *)&(table->MemoryBootLevel));
> 
> +	if (result)
> +		return result;
> +
>  	table->BootVddc  = data->vbios_boot_state.vddc_bootup_value *
>  			VOLTAGE_SCALE;
>  	table->BootVddci = data->vbios_boot_state.vddci_bootup_value *
> --
> 2.7.4