linux-kernel - Re: linux-5.4-rc8/drivers/char/tpm/tpm1-cmd.c:735: possible missing return value check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20191118092721.GA154812@kroah.com>
Date:   Mon, 18 Nov 2019 10:27:21 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     David Binderman <dcb314@...mail.com>
Cc:     "peterhuewe@....de" <peterhuewe@....de>,
        "jarkko.sakkinen@...ux.intel.com" <jarkko.sakkinen@...ux.intel.com>,
        "jgg@...pe.ca" <jgg@...pe.ca>, Arnd Bergmann <arnd@...db.de>,
        "linux-integrity@...r.kernel.org" <linux-integrity@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: linux-5.4-rc8/drivers/char/tpm/tpm1-cmd.c:735: possible missing
 return value check

On Mon, Nov 18, 2019 at 09:24:32AM +0000, David Binderman wrote:
> Hello there,
> 
> linux-5.4-rc8/drivers/char/tpm/tpm1-cmd.c:735:5: style: Variable 'rc' is reassigned a value before the old one has been used. [redundantAssignment]
> 
> Source code is
> 
>     if (tpm_suspend_pcr)
>         rc = tpm1_pcr_extend(chip, tpm_suspend_pcr, dummy_hash,
>                      "extending dummy pcr before suspend");
> 
>     rc = tpm_buf_init(&buf, TPM_TAG_RQU_COMMAND, TPM_ORD_SAVESTATE);
> 
> Suggest add test of rc after call to tpm1_pcr_extend.

Great, how about you submit a patch to resolve this?  That way you can
get the full credit for finding and resolveing the issue?

thanks,

greg k-h