| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <427143e8-d422-3d5c-7e66-7ad063841bb2@redhat.com>
Date: Mon, 18 Nov 2019 18:42:34 +0800
From: Jason Wang <jasowang@...hat.com>
To: kvm@...r.kernel.org, linux-s390@...r.kernel.org,
linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
intel-gfx@...ts.freedesktop.org,
intel-gvt-dev@...ts.freedesktop.org, kwankhede@...dia.com,
alex.williamson@...hat.com, mst@...hat.com, tiwei.bie@...el.com
Cc: virtualization@...ts.linux-foundation.org, netdev@...r.kernel.org,
cohuck@...hat.com, maxime.coquelin@...hat.com,
cunming.liang@...el.com, zhihong.wang@...el.com,
rob.miller@...adcom.com, xiao.w.wang@...el.com,
haotian.wang@...ive.com, zhenyuw@...ux.intel.com,
zhi.a.wang@...el.com, jani.nikula@...ux.intel.com,
joonas.lahtinen@...ux.intel.com, rodrigo.vivi@...el.com,
airlied@...ux.ie, daniel@...ll.ch, farman@...ux.ibm.com,
pasic@...ux.ibm.com, sebott@...ux.ibm.com, oberpar@...ux.ibm.com,
heiko.carstens@...ibm.com, gor@...ux.ibm.com,
borntraeger@...ibm.com, akrowiak@...ux.ibm.com,
freude@...ux.ibm.com, lingshan.zhu@...el.com, eperezma@...hat.com,
lulu@...hat.com, parav@...lanox.com,
christophe.de.dinechin@...il.com, kevin.tian@...el.com,
stefanha@...hat.com, rdunlap@...radead.org, hch@...radead.org,
gregkh@...uxfoundation.org, jgg@...lanox.com
Subject: Re: [PATCH V12 0/6] mdev based hardware virtio offloading support
On 2019/11/18 下午2:16, Jason Wang wrote:
> Hi all:
>
> There are hardwares that can do virtio datapath offloading while
> having its own control path. This path tries to implement a mdev based
> unified API to support using kernel virtio driver to drive those
> devices. This is done by introducing a new mdev transport for virtio
> (virtio_mdev) and register itself as a new kind of mdev driver. Then
> it provides a unified way for kernel virtio driver to talk with mdev
> device implementation.
>
> Though the series only contains kernel driver support, the goal is to
> make the transport generic enough to support userspace drivers. This
> means vhost-mdev[1] could be built on top as well by resuing the
> transport.
>
> A sample driver is also implemented which simulate a virito-net
> loopback ethernet device on top of vringh + workqueue. This could be
> used as a reference implementation for real hardware driver.
>
> Also a real IFC VF driver was also posted here[2] which is a good
> reference for vendors who is interested in their own virtio datapath
> offloading product.
>
> Consider mdev framework only support VFIO device and driver right now,
> this series also extend it to support other types. This is done
> through decoupling VFIO specific bits out of mdev core and make mdev
> an independent module that allows to be used by multiple types of
> buses.
>
> Pktgen test was done with virito-net + mvnet loop back device.
>
> Please review.
>
> [1] https://lkml.org/lkml/2019/11/5/424
> [2] https://lkml.org/lkml/2019/11/5/227
>
> Changes from V11:
> - decouple VFIO specific bits out of mdev core
> - make mdev an indepdent module to allow buses other than VFIO mdev
> - allow structure composition of mdev through specifiy the size of
> mdev structure
> - introduce mdev_vfio structure and store the VFIO specific callbacks
> there
> - don't use "mdev" bus for virtio, use a new "mdev_virtio" bus, and
> store the virtio specific callbacks in mdev_virtio structure.
> - do the class_id, matching on top of "mdev_virtio" bus
It looks to me this series get some conflicts with gvt-linux.git. Will
fix them and post v13.
Thanks
>
> Changes from V10:
> - rename mvnet to mvnet_loopback
> - fix typo in the help text for sample Kconfig
>
> Changes from V9:
> - Tweak the help text for virito-mdev kconfig
>
> Changes from V8:
> - try silent checkpatch, some are still there becuase they were inherited
> from virtio_config_ops which needs to be resolved in an independent series
> - tweak on the comment and doc
> - remove VIRTIO_MDEV_F_VERSION_1 completely
> - rename CONFIG_VIRTIO_MDEV_DEVICE to CONFIG_VIRTIO_MDEV
>
> Changes from V7:
> - drop {set|get}_mdev_features for virtio
> - typo and comment style fixes
>
> Changes from V6:
> - rename ops files and compile guard
>
> Changes from V5:
> - use dev_warn() instead of WARN(1) when class id is not set
> - validate id_table before trying to do matching between device and
> driver
> - add wildcard for modpost script
> - use unique name for id_table
> - move get_mdev_features() to be the first member of virtio_device_ops
> and more comments for it
> - typo fixes for the comments above virtio_mdev_ops
>
> Changes from V4:
> - keep mdev_set_class() for the device that doesn't use device ops
> - use union for device ops pointer in mdev_device
> - introduce class specific helper for getting is device ops
> - use WARN_ON instead of BUG_ON in mdev_set_virtio_ops
> - explain details of get_mdev_features() and get_vendor_id()
> - distinguish the optional virito device ops from mandatory ones and
> make get_generation() optional
> - rename vfio_mdev.h to vfio_mdev_ops.h, rename virito_mdev.h to
> virtio_mdev_ops.h
> - don't abuse version fileds in virtio_mdev structure, use features
> instead
> - fix warning during device remove
> - style & docs tweaks and typo fixes
>
> Changes from V3:
> - document that class id (device ops) must be specified in create()
> - add WARN() when trying to set class_id when it has already set
> - add WARN() when class_id is not specified in create() and correctly
> return an error in this case
> - correct the prototype of mdev_set_class() in the doc
> - add documention of mdev_set_class()
> - remove the unnecessary "class_id_fail" label when class id is not
> specified in create()
> - convert id_table in vfio_mdev to const
> - move mdev_set_class and its friends after mdev_uuid()
> - suqash the patch of bus uevent into patch of introducing class id
> - tweak the words in the docs per Cornelia suggestion
> - tie class_id and device ops through class specific initialization
> routine like mdev_set_vfio_ops()
> - typos fixes in the docs of virtio-mdev callbacks
> - document the usage of virtqueues in struct virtio_mdev_device
> - remove the useless vqs array in struct virtio_mdev_device
> - rename MDEV_ID_XXX to MDEV_CLASS_ID_XXX
>
> Changes from V2:
> - fail when class_id is not specified
> - drop the vringh patch
> - match the doc to the code
> - tweak the commit log
> - move device_ops from parent to mdev device
> - remove the unused MDEV_ID_VHOST
>
> Changes from V1:
> - move virtio_mdev.c to drivers/virtio
> - store class_id in mdev_device instead of mdev_parent
> - store device_ops in mdev_device instead of mdev_parent
> - reorder the patch, vringh fix comes first
> - really silent compiling warnings
> - really switch to use u16 for class_id
> - uevent and modpost support for mdev class_id
> - vraious tweaks per comments from Parav
>
> Changes from RFC-V2:
> - silent compile warnings on some specific configuration
> - use u16 instead u8 for class id
> - reseve MDEV_ID_VHOST for future vhost-mdev work
> - introduce "virtio" type for mvnet and make "vhost" type for future
> work
> - add entries in MAINTAINER
> - tweak and typos fixes in commit log
>
> Changes from RFC-V1:
> - rename device id to class id
> - add docs for class id and device specific ops (device_ops)
> - split device_ops into seperate headers
> - drop the mdev_set_dma_ops()
> - use device_ops to implement the transport API, then it's not a part
> of UAPI any more
> - use GFP_ATOMIC in mvnet sample device and other tweaks
> - set_vring_base/get_vring_base support for mvnet device
>
>
> Jason Wang (6):
> mdev: make mdev bus agnostic
> mdev: split out VFIO bus specific parent ops
> mdev: move to drivers/
> mdev: introduce mediated virtio bus
> virtio: introduce a mdev based transport
> docs: sample driver to demonstrate how to implement virtio-mdev
> framework
>
> .../driver-api/vfio-mediated-device.rst | 94 ++-
> MAINTAINERS | 11 +-
> drivers/Kconfig | 2 +
> drivers/Makefile | 1 +
> drivers/gpu/drm/i915/gvt/kvmgt.c | 26 +-
> drivers/mdev/Kconfig | 29 +
> drivers/mdev/Makefile | 7 +
> drivers/{vfio => }/mdev/mdev_core.c | 107 ++-
> drivers/{vfio => }/mdev/mdev_driver.c | 29 +-
> drivers/{vfio => }/mdev/mdev_private.h | 18 +-
> drivers/{vfio => }/mdev/mdev_sysfs.c | 0
> drivers/mdev/vfio.c | 76 ++
> drivers/mdev/virtio.c | 126 ++++
> drivers/s390/cio/vfio_ccw_ops.c | 23 +-
> drivers/s390/crypto/vfio_ap_ops.c | 34 +-
> drivers/s390/crypto/vfio_ap_private.h | 2 +-
> drivers/vfio/mdev/Kconfig | 11 -
> drivers/vfio/mdev/Makefile | 4 -
> drivers/vfio/mdev/vfio_mdev.c | 45 +-
> drivers/vfio/vfio_iommu_type1.c | 6 +-
> drivers/virtio/Kconfig | 13 +
> drivers/virtio/Makefile | 1 +
> drivers/virtio/virtio_mdev.c | 409 +++++++++++
> include/linux/mdev.h | 49 +-
> include/linux/mdev_vfio.h | 68 ++
> include/linux/mdev_virtio.h | 168 +++++
> include/linux/mod_devicetable.h | 8 +
> samples/Kconfig | 10 +
> samples/vfio-mdev/Makefile | 1 +
> samples/vfio-mdev/mbochs.c | 26 +-
> samples/vfio-mdev/mdpy.c | 27 +-
> samples/vfio-mdev/mtty.c | 24 +-
> samples/vfio-mdev/mvnet_loopback.c | 690 ++++++++++++++++++
> scripts/mod/devicetable-offsets.c | 3 +
> scripts/mod/file2alias.c | 12 +
> 35 files changed, 1924 insertions(+), 236 deletions(-)
> create mode 100644 drivers/mdev/Kconfig
> create mode 100644 drivers/mdev/Makefile
> rename drivers/{vfio => }/mdev/mdev_core.c (76%)
> rename drivers/{vfio => }/mdev/mdev_driver.c (83%)
> rename drivers/{vfio => }/mdev/mdev_private.h (81%)
> rename drivers/{vfio => }/mdev/mdev_sysfs.c (100%)
> create mode 100644 drivers/mdev/vfio.c
> create mode 100644 drivers/mdev/virtio.c
> create mode 100644 drivers/virtio/virtio_mdev.c
> create mode 100644 include/linux/mdev_vfio.h
> create mode 100644 include/linux/mdev_virtio.h
> create mode 100644 samples/vfio-mdev/mvnet_loopback.c
>
Powered by blists - more mailing lists