linux-kernel - Re: [PATCH v3] mm: get rid of odd jump labels in find_mergeable_anon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon, 18 Nov 2019 11:31:09 +0000
From:   linmiaohe <linmiaohe@...wei.com>
To:     David Hildenbrand <david@...hat.com>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "richardw.yang@...ux.intel.com" <richardw.yang@...ux.intel.com>,
        "sfr@...b.auug.org.au" <sfr@...b.auug.org.au>,
        "rppt@...ux.ibm.com" <rppt@...ux.ibm.com>,
        "jannh@...gle.com" <jannh@...gle.com>,
        "steve.capper@....com" <steve.capper@....com>,
        "catalin.marinas@....com" <catalin.marinas@....com>,
        "aarcange@...hat.com" <aarcange@...hat.com>,
        "walken@...gle.com" <walken@...gle.com>,
        "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
        "tiny.windzz@...il.com" <tiny.windzz@...il.com>,
        "jhubbard@...dia.com" <jhubbard@...dia.com>
CC:     "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] mm: get rid of odd jump labels in
 find_mergeable_anon_vma()

David Hildenbrand wrote:
> On 18.11.19 07:39, linmiaohe wrote:
>> From: Miaohe Lin <linmiaohe@...wei.com>
>> 
>> The jump labels try_prev and none are not really needed in 
>> find_mergeable_anon_vma(), eliminate them to improve readability.
>
>I think you can get rid of near completely as well
>
>	if (vma->vm_next) {
>		anon_vma = reusable_anon_vma(near, vma, vma->vm_next);
>		if (anon_vma)
>			return anon_vma;
>	}
>
>...
>
>Apart from  that looks good to me.
>
>>   
>> -	anon_vma = reusable_anon_vma(near, vma, near);
>> -	if (anon_vma)
>> -		return anon_vma;
>> -try_prev:
>> +	/* Try prev next. */
>>   	near = vma->vm_prev;
>> -	if (!near)

Thanks for your advice again. I will get rid of near completely in v4. Thanks a lot.