linux-kernel - Re: [PATCH v2 1/4] scsi: ufs: Recheck bkops level if bkops is disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 18 Nov 2019 18:39:43 +0530
From:   Alim Akhtar <alim.akhtar@...il.com>
To:     Can Guo <cang@....qualcomm.com>
Cc:     asutoshd@...eaurora.org, nguyenb@...eaurora.org,
        rnayak@...eaurora.org, linux-scsi@...r.kernel.org,
        kernel-team@...roid.com, saravanak@...gle.com,
        Mark Salyzyn <salyzyn@...gle.com>,
        Can Guo <cang@...eaurora.org>,
        Alim Akhtar <alim.akhtar@...sung.com>,
        Avri Altman <avri.altman@....com>,
        Pedro Sousa <pedrom.sousa@...opsys.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Stanley Chu <stanley.chu@...iatek.com>,
        Bean Huo <beanhuo@...ron.com>,
        Tomas Winkler <tomas.winkler@...el.com>,
        Venkat Gopalakrishnan <venkatg@...eaurora.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/4] scsi: ufs: Recheck bkops level if bkops is disabled

Hi Can

On Mon, Nov 18, 2019 at 9:21 AM Can Guo <cang@....qualcomm.com> wrote:
>
> From: Asutosh Das <asutoshd@...eaurora.org>
>
> Bkops level should be rechecked upon receiving an exception.
> Currently the bkops level is being cached and never updated.
>
> Update the same each time the level is checked.
> Also do not use the cached bkops level value if it is disabled
> and then enabled.
>
> Fixes: afdfff59a0e0 (scsi: ufs: handle non spec compliant bkops behaviour by device)
> Signed-off-by: Asutosh Das <asutoshd@...eaurora.org>
> Signed-off-by: Can Guo <cang@...eaurora.org>
> Reviewed-by: Bean Huo <beanhuo@...ron.com>
> ---
Feel free to add
Reviewed-by: Alim Akhtar <alim.akhtar@...sung.com>
Ran these patches on exynos7 platfrom, and no regression observed,
basic read/write works, so
Tested-by: Alim Akhtar <alim.akhtar@...sung.com
>
>  drivers/scsi/ufs/ufshcd.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index 3910c58..8e7c362 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -5099,6 +5099,7 @@ static int ufshcd_disable_auto_bkops(struct ufs_hba *hba)
>
>         hba->auto_bkops_enabled = false;
>         trace_ufshcd_auto_bkops_state(dev_name(hba->dev), "Disabled");
> +       hba->is_urgent_bkops_lvl_checked = false;
>  out:
>         return err;
>  }
> @@ -5123,6 +5124,7 @@ static void ufshcd_force_reset_auto_bkops(struct ufs_hba *hba)
>                 hba->ee_ctrl_mask &= ~MASK_EE_URGENT_BKOPS;
>                 ufshcd_disable_auto_bkops(hba);
>         }
> +       hba->is_urgent_bkops_lvl_checked = false;
>  }
>
>  static inline int ufshcd_get_bkops_status(struct ufs_hba *hba, u32 *status)
> @@ -5169,6 +5171,7 @@ static int ufshcd_bkops_ctrl(struct ufs_hba *hba,
>                 err = ufshcd_enable_auto_bkops(hba);
>         else
>                 err = ufshcd_disable_auto_bkops(hba);
> +       hba->urgent_bkops_lvl = curr_status;
>  out:
>         return err;
>  }
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>


-- 
Regards,
Alim