linux-kernel - Re: [PATCH] rtc: msm6242: Fix reading of 10-hour digit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191118141854.GE3632@piout.net>
Date:   Mon, 18 Nov 2019 15:18:54 +0100
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     Kars de Jong <jongk@...ux-m68k.org>
Cc:     Alessandro Zummo <a.zummo@...ertech.it>, linux-rtc@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Geert Uytterhoeven <geert@...ux-m68k.org>
Subject: Re: [PATCH] rtc: msm6242: Fix reading of 10-hour digit

On 16/11/2019 12:05:48+0100, Kars de Jong wrote:
> The driver was reading the wrong register as the 10-hour digit due to
> a misplaced ')'. It was in fact reading the 1-second digit register due
> to this bug.
> 
> Also remove the use of a magic number for the hour mask and use the define
> for it which was already present.
> 
> Cc: Geert Uytterhoeven <geert@...ux-m68k.org>
> Tested-by: Kars de Jong <jongk@...ux-m68k.org>
> Signed-off-by: Kars de Jong <jongk@...ux-m68k.org>
> ---
>  drivers/rtc/rtc-msm6242.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
Applied, thanks.

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com