[<prev] [next>] [day] [month] [year] [list]
Message-Id: <20191118024755.21456-1-hslester96@gmail.com>
Date: Mon, 18 Nov 2019 10:47:55 +0800
From: Chuhong Yuan <hslester96@...il.com>
To: unlisted-recipients:; (no To-header on input)
Cc: Eric Anholt <eric@...olt.net>, David Airlie <airlied@...ux.ie>,
Daniel Vetter <daniel@...ll.ch>,
dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
Chuhong Yuan <hslester96@...il.com>
Subject: [PATCH] drm/v3d: add missed pm_runtime_disable
The driver forgets to call pm_runtime_disable in probe failure
and remove.
Add the missed calls to fix it.
Signed-off-by: Chuhong Yuan <hslester96@...il.com>
---
drivers/gpu/drm/v3d/v3d_drv.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/v3d/v3d_drv.c b/drivers/gpu/drm/v3d/v3d_drv.c
index 3506ae2723ae..e109bb8cd67d 100644
--- a/drivers/gpu/drm/v3d/v3d_drv.c
+++ b/drivers/gpu/drm/v3d/v3d_drv.c
@@ -333,6 +333,7 @@ static int v3d_platform_drm_probe(struct platform_device *pdev)
dev_destroy:
drm_dev_put(drm);
dma_free:
+ pm_runtime_disable(dev);
dma_free_wc(dev, 4096, v3d->mmu_scratch, v3d->mmu_scratch_paddr);
dev_free:
kfree(v3d);
@@ -350,6 +351,8 @@ static int v3d_platform_drm_remove(struct platform_device *pdev)
drm_dev_put(drm);
+ pm_runtime_disable(v3d->dev);
+
dma_free_wc(v3d->dev, 4096, v3d->mmu_scratch, v3d->mmu_scratch_paddr);
return 0;
--
2.24.0
Powered by blists - more mailing lists