linux-kernel - Re: [PATCH -next v2] mm/vmscan: fix some -Wenum-conversion warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191118182547.GA372119@cmpxchg.org>
Date:   Mon, 18 Nov 2019 13:25:47 -0500
From:   Johannes Weiner <hannes@...xchg.org>
To:     Qian Cai <cai@....pw>
Cc:     akpm@...ux-foundation.org, surenb@...gle.com, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next v2] mm/vmscan: fix some -Wenum-conversion warnings

On Fri, Nov 15, 2019 at 03:11:37PM -0500, Qian Cai wrote:
> The -next commit "mm: vmscan: enforce inactive:active ratio at the
> reclaim root" [1] introduced some Clang -Wenum-conversion warnings,
> 
> mm/vmscan.c:2216:39: warning: implicit conversion from enumeration type
> 'enum lru_list' to different enumeration type 'enum node_stat_item'
> [-Wenum-conversion]
>         inactive = lruvec_page_state(lruvec, inactive_lru);
>                    ~~~~~~~~~~~~~~~~~         ^~~~~~~~~~~~
> mm/vmscan.c:2217:37: warning: implicit conversion from enumeration type
> 'enum lru_list' to different enumeration type 'enum node_stat_item'
> [-Wenum-conversion]
>         active = lruvec_page_state(lruvec, active_lru);
>                  ~~~~~~~~~~~~~~~~~         ^~~~~~~~~~
> mm/vmscan.c:2746:42: warning: implicit conversion from enumeration type
> 'enum lru_list' to different enumeration type 'enum node_stat_item'
> [-Wenum-conversion]
>         file = lruvec_page_state(target_lruvec, LRU_INACTIVE_FILE);
>                ~~~~~~~~~~~~~~~~~                ^~~~~~~~~~~~~~~~~
> 
> Since it guarantees the relative order between the LRU items, fix it by
> using NR_LRU_BASE for the translation.
> 
> [1] http://lkml.kernel.org/r/20191107205334.158354-4-hannes@cmpxchg.org
> 
> Signed-off-by: Qian Cai <cai@....pw>

Acked-by: Johannes Weiner <hannes@...xchg.org>

Thanks Qian!

Andrew, this is a fix for "mm: vmscan: enforce inactive:active ratio
at the reclaim root". Could you please fold this into that?