linux-kernel - Re: [PATCH] staging: octeon: indent with tabs instead of spaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191118190018.GA5604@kadam>
Date:   Mon, 18 Nov 2019 22:01:28 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Giovanni Gherdovich <bobdc9664@...nam.cz>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        Aaro Koskinen <aaro.koskinen@....fi>
Subject: Re: [PATCH] staging: octeon: indent with tabs instead of spaces

On Mon, Nov 18, 2019 at 07:38:52PM +0100, Giovanni Gherdovich wrote:
> Remove a coding style error from the Octeon driver's tree and keep
> checkpatch.pl a little quieter.
> 
> Being a white-spaces patch the chances of breakage are minimal; we don't
> have the hardware to run this driver so we built it with COMPILE_TEST
> enabled on an x86 machine.

Next time put this sort of comment under the --- cut off line so that we
sound like we're bursting with confidence in the permanent git log.  ;)

> 
> Signed-off-by: Giovanni Gherdovich <bobdc9664@...nam.cz>
> ---
  ^^^

>  drivers/staging/octeon/octeon-stubs.h | 32 ++++++++++++++++----------------
>  1 file changed, 16 insertions(+), 16 deletions(-)

Anyway, looks good.

Reviewed-by: Dan Carpenter <dan.carpenter@...cle.com>

regards,
dan carpenter