linux-kernel - Re: [PATCH v2 02/13] exfat: add super block operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191119085639.kr4esp72dix4lvok@beryllium.lan>
Date:   Tue, 19 Nov 2019 09:56:39 +0100
From:   Daniel Wagner <dwagner@...e.de>
To:     Namjae Jeon <namjae.jeon@...sung.com>
Cc:     linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        gregkh@...uxfoundation.org, valdis.kletnieks@...edu, hch@....de,
        linkinjeon@...il.com, Markus.Elfring@....de, sj1557.seo@...sung.com
Subject: Re: [PATCH v2 02/13] exfat: add super block operations

Hi,

On Tue, Nov 19, 2019 at 02:10:56AM -0500, Namjae Jeon wrote:
> +static void exfat_put_super(struct super_block *sb)
> +{
> +	struct exfat_sb_info *sbi = EXFAT_SB(sb);
> +
> +	mutex_lock(&sbi->s_lock);
> +	if (READ_ONCE(sbi->s_dirt)) {
> +		WRITE_ONCE(sbi->s_dirt, true);

No idea what the code does. But I was just skimming over and find the
above pattern somehow strange. Shouldn't this be something like

	if (!READ_ONCE(sbi->s_dirt)) {
		WRITE_ONCE(sbi->s_dirt, true);

?

Thanks,
Daniel