linux-kernel - Re: [PATCH v3 1/2] dt-bindings: interconnect: Add OSM L3 DT bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0101016e83360189-588bff57-180a-400e-8b5f-e9517992feb4-000000@us-west-2.amazonses.com>
Date:   Tue, 19 Nov 2019 10:29:45 +0000
From:   sibis@...eaurora.org
To:     Stephen Boyd <sboyd@...nel.org>
Cc:     georgi.djakov@...aro.org, robh+dt@...nel.org,
        bjorn.andersson@...aro.org, agross@...nel.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, mark.rutland@....com,
        evgreen@...omium.org, daidavid1@...eaurora.org,
        saravanak@...gle.com, viresh.kumar@...aro.org
Subject: Re: [PATCH v3 1/2] dt-bindings: interconnect: Add OSM L3 DT bindings

Hey Stephen,

Thanks for taking time to
review the series.

On 2019-11-19 06:01, Stephen Boyd wrote:
> Quoting Sibi Sankar (2019-11-18 07:45:21)
>> diff --git 
>> a/Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml 
>> b/Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml
>> new file mode 100644
>> index 0000000000000..fec8289ceeeed
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml
>> @@ -0,0 +1,56 @@
>> +examples:
>> +  - |
>> +    osm_l3: interconnect@...41000 {
>> +      compatible = "qcom,sdm845-osm-l3";
>> +      reg = <0x17d41000 0x1400>;
>> +
>> +      clocks = <&rpmhcc 0>, <&gcc 165>;
> 
> Can you use #define names here? That would make it clearer what sort of
> clk is expected here.

yes will do that.

> 
>> +      clock-names = "xo", "alternate";
>> +
>> +      #interconnect-cells = <1>;
>> +    };