linux-kernel - Re: [PATCH] ASoC: rsnd: fix DALIGN register for SSIU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 19 Nov 2019 11:43:12 +0100
From:   Eugeniu Rosca <erosca@...adit-jv.com>
To:     Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
CC:     Eugeniu Rosca <erosca@...adit-jv.com>,
        Jiada Wang <jiada_wang@...tor.com>,
        Mark Brown <broonie@...nel.org>, <alsa-devel@...a-project.org>,
        <linux-kernel@...r.kernel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Eugeniu Rosca <roscaeugeniu@...il.com>,
        Nilkanth Ahirrao <external.anilkanth@...adit-jv.com>,
        Andrew Gabbasov <andrew_gabbasov@...tor.com>
Subject: Re: [PATCH] ASoC: rsnd: fix DALIGN register for SSIU

Hello Morimoto-san,

On Tue, Nov 19, 2019 at 09:46:12AM +0900, Kuninori Morimoto wrote:

[..]

> Basically I have no objection.
> But we can reuse dalign_values[0][x] value ?
> 
> 	id  = 0;
> 	if ((snd_pcm_format_width(runtime->format) != 16) ||
> 	    (mod != target)) {
> 		inv = 0;
> 		if (mod == ssiu))
> 			id = rsnd_mod_id_sub(mod);
> 	/* Target mod needs inverted DALIGN when 16bit */
> 	} else {
> 		inv = 1;
> 		if (mod == ssiu)
> 			id = rsnd_mod_id_sub(mod);
> 	}
> 
> 	return dalign_values[id][inv];

Thank you for your review comment.
We will soon push a v2.

-- 
Best Regards,
Eugeniu