linux-kernel - Re: [PATCH V2] misc: rtsx: Fix impossible condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191119123724.GA1975017@kroah.com>
Date:   Tue, 19 Nov 2019 13:37:24 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     rui_feng@...lsil.com.cn
Cc:     arnd@...db.de, dan.carpenter@...cle.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2] misc: rtsx: Fix impossible condition

On Tue, Nov 19, 2019 at 04:26:30PM +0800, rui_feng@...lsil.com.cn wrote:
> From: Rui Feng <rui_feng@...lsil.com.cn>
> 
> A u8 can only go up to 255, condition n > 396 is
> impossible, so change u8 to u16.
> 
> Signed-off-by: Rui Feng <rui_feng@...lsil.com.cn>
> ---
>  drivers/misc/cardreader/rts5261.c | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)

What changed from v1?  Always put that below the --- line as the
documentation asks you to.

Please fix up and send a v3.

thanks,

greg k-h