linux-kernel - Re: [PATCH v11 02/11] media: staging: rkisp1: add document for rkisp1 meta buffer format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAFQd5BPwSnY51vJboCB6Hr2Yz4jMqt4VWLNNLTpiwenGo_Wew@mail.gmail.com>
Date:   Tue, 19 Nov 2019 22:03:59 +0900
From:   Tomasz Figa <tfiga@...omium.org>
To:     Ezequiel Garcia <ezequiel@...labora.com>
Cc:     Jacob Chen <jacobchen110@...il.com>,
        Helen Koike <helen.koike@...labora.com>,
        Hans Verkuil <hverkuil@...all.nl>,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
        Mark Rutland <mark.rutland@....com>,
        linux-devicetree <devicetree@...r.kernel.org>,
        Eddie Cai <eddie.cai.linux@...il.com>, kernel@...labora.com,
        Heiko Stuebner <heiko@...ech.de>,
        Jacob Chen <jacob-chen@...k-chips.com>,
        Greg KH <gregkh@...uxfoundation.org>,
        Jeffy Chen <jeffy.chen@...k-chips.com>,
        钟以崇 <zyc@...k-chips.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Hans Verkuil <hans.verkuil@...co.com>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Shunqian Zheng <zhengsq@...k-chips.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        "list@....net:IOMMU DRIVERS <iommu@...ts.linux-foundation.org>, Joerg
        Roedel <joro@...tes.org>," <linux-arm-kernel@...ts.infradead.org>,
        Linux Media Mailing List <linux-media@...r.kernel.org>
Subject: Re: [PATCH v11 02/11] media: staging: rkisp1: add document for rkisp1
 meta buffer format

On Tue, Nov 19, 2019 at 9:56 PM Ezequiel Garcia <ezequiel@...labora.com> wrote:
>
> Hello Jacob,
>
> Thanks for the insight.
>
> On Tue, 2019-11-19 at 18:16 +0800, Jacob Chen wrote:
> > Hi Helen ,
> >
> > Helen Koike <helen.koike@...labora.com> 于2019年11月14日周四 下午6:59写道：
> > >
> > >
> > > On 11/14/19 6:21 AM, Hans Verkuil wrote:
> > > > On 11/14/19 6:12 AM, Helen Koike wrote:
> > > > > From: Jacob Chen <jacob2.chen@...k-chips.com>
> > > > >
> > > > > This commit add document for rkisp1 meta buffer format
> > > > >
> > > > > Signed-off-by: Jacob Chen <jacob-chen@...k-chips.com>
> > > > > [refactored for upstream]
> > > > > Signed-off-by: Helen Koike <helen.koike@...labora.com>
> > > >
> > > > checkpatch gives me:
> > > >
> > > > WARNING: Missing Signed-off-by: line by nominal patch author 'Jacob Chen <jacob2.chen@...k-chips.com>'
> > > >
> > > > Looking at this series I see duplicate Signed-off-by entries for Jacob Chen and a total
> > > > of three different email addresses:
> > > >
> > > > jacob2.chen@...k-chips.com
> > > > jacob-chen@...k-chips.com
> > > > cc@...k-chips.com
> > >
> > > And I see a name in the Maintainers file as Jacob Chen <jacob-chen@...wrt.com>.
> > > I was wondering if I could replace the email by jacob-chen@...wrt.com, or if I should
> > > keep the original ones.
> > >
> > > Helen
> > >
> >
> > "jacob2.chen@...k-chips.com"/"jacob-chen@...k-chips.com" is me and
> > "cc@...k-chips.com" is another one.
> > ' jacob-chen@...k-chips.com' is invalid now,  so you could replace the
> > email by 'jacob-chen@...wrt.com'.
> >
>
> Authorship and SOB can't be changed freely, the original must be retained,
> because this gives proper credit to the company that sponsored the work.
>
> I.e. if your mail used to be jacob2.chen at rock-chips.com, then I think
> we can use that. And if cc at rock-chips.com is a different engineer,
> also named Jacob Chen, perhaps we can mention that somewhere to reduce the
> confusion.

Some patches have been developed by Jacob <jacob2.chen at
rock-chips.com>, some by Jacob <cc at rock-chips.com> and some by
both.

Some patches have been also re-posted by Jacob after leaving Rockchip
AFAIR, from the <jacob-chen at iotwrt.com> address. Those should have
<jacob2.chen at rock-chips.com> as From: and include sign-offs from
both <jacob2.chen at rock-chips.com> and <jacob-chen at iotwrt.com>.

So the conclusion is that the original sign-offs should be retained
+/- typos fixed.

For typos, was <jacob-chen at rock-chips.com> a typo of <jacob2.chen
at rock-chips.com> or a typo of <jacob-chen at iotwrt.com>?

Best regards,
Tomasz