linux-kernel - Re: [PATCH] perf vendor events: Make the power8/power9 event files valid JSON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-Id: <529EC552-AF92-45FD-9043-AB5A570B29AD@gmail.com>
Date:   Mon, 18 Nov 2019 21:21:07 -0600
From:   Subho Banerjee <ssbanerje@...il.com>
To:     Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Mamatha Inamdar <mamatha4@...ux.vnet.ibm.com>,
        Ravi Bangoria <ravi.bangoria@...ux.ibm.com>,
        Michael Petlan <mpetlan@...hat.com>,
        Madhavan Srinivasan <maddy@...ux.vnet.ibm.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf vendor events: Make the power8/power9 event files
 valid JSON

Hi Arnaldo,
I am uncertain which commit you are working on. 

The command that you sent fails on the latest commit of the master branch (af42d3466bdc8f39806b26f593604fdc54140bcb) on kernel/git/torvalds/linux.git.

Is there a more up to date version of the perf tools that I should be looking at instead of what is in the kernel repo?

ssbaner2@...rak:~/linux$ git rev-parse --verify HEAD
af42d3466bdc8f39806b26f593604fdc54140bcb


ssbaner2@...rak:~/linux$ diffstat -l -p1 0001-perf-vendor-events-Make-the-power8-power9-event-file.patch | while read filename ; do echo $filename ; cat $filename | json_verify ; done
tools/perf/pmu-events/arch/powerpc/power8/cache.json
parse error: invalid object key (must be a string)
                                        [   {,     "EventCode": "0x4c0
                     (right here) ------^
JSON is invalid
tools/perf/pmu-events/arch/powerpc/power8/floating-point.json
parse error: invalid object key (must be a string)
                                        [   {,     "EventCode": "0x200
                     (right here) ------^
JSON is invalid
tools/perf/pmu-events/arch/powerpc/power8/frontend.json
parse error: invalid object key (must be a string)
                                        [   {,     "EventCode": "0x250
                     (right here) ------^
JSON is invalid
tools/perf/pmu-events/arch/powerpc/power8/marked.json
parse error: invalid object key (must be a string)
                                        [   {,     "EventCode": "0x351
                     (right here) ------^
JSON is invalid
tools/perf/pmu-events/arch/powerpc/power8/memory.json
parse error: invalid object key (must be a string)
                                        [   {,     "EventCode": "0x100
                     (right here) ------^
JSON is invalid
tools/perf/pmu-events/arch/powerpc/power8/other.json
parse error: invalid object key (must be a string)
                                        [   {,     "EventCode": "0x1f0
                     (right here) ------^
JSON is invalid


Regards,
Subho

> On Nov 18, 2019, at 9:18 PM, Subho Banerjee <ssbanerje@...il.com> wrote:
> 
> Hi Arnaldo,
> I am uncertain which commit you are working on. 
> 
> The command that you sent fails on the latest commit of the master branch (af42d3466bdc8f39806b26f593604fdc54140bcb) on kernel/git/torvalds/linux.git.
> 
> Is there a more up to date version of the perf tools that I should be looking at instead of what is in the kernel repo?
> 
> ssbaner2@...rak:~/linux$ git rev-parse --verify HEAD
> af42d3466bdc8f39806b26f593604fdc54140bcb
> 
> 
> ssbaner2@...rak:~/linux$ diffstat -l -p1 0001-perf-vendor-events-Make-the-power8-power9-event-file.patch | while read filename ; do echo $filename ; cat $filename | json_verify ; done
> tools/perf/pmu-events/arch/powerpc/power8/cache.json
> parse error: invalid object key (must be a string)
>                                         [   {,     "EventCode": "0x4c0
>                      (right here) ------^
> JSON is invalid
> tools/perf/pmu-events/arch/powerpc/power8/floating-point.json
> parse error: invalid object key (must be a string)
>                                         [   {,     "EventCode": "0x200
>                      (right here) ------^
> JSON is invalid
> tools/perf/pmu-events/arch/powerpc/power8/frontend.json
> parse error: invalid object key (must be a string)
>                                         [   {,     "EventCode": "0x250
>                      (right here) ------^
> JSON is invalid
> tools/perf/pmu-events/arch/powerpc/power8/marked.json
> parse error: invalid object key (must be a string)
>                                         [   {,     "EventCode": "0x351
>                      (right here) ------^
> JSON is invalid
> tools/perf/pmu-events/arch/powerpc/power8/memory.json
> parse error: invalid object key (must be a string)
>                                         [   {,     "EventCode": "0x100
>                      (right here) ------^
> JSON is invalid
> tools/perf/pmu-events/arch/powerpc/power8/other.json
> parse error: invalid object key (must be a string)
>                                         [   {,     "EventCode": "0x1f0
>                      (right here) ------^
> JSON is invalid
> 
> 
> Regards,
> Subho