linux-kernel - Re: [PATCH v3 0/7] perf/probe: Support multiprobe and immediates with fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191119143347.GB22731@kernel.org>
Date:   Tue, 19 Nov 2019 11:33:47 -0300
From:   Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
To:     Masami Hiramatsu <mhiramat@...nel.org>
Cc:     Ingo Molnar <mingo@...hat.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        linux-kernel@...r.kernel.org,
        Tom Zanussi <tom.zanussi@...ux.intel.com>,
        Ravi Bangoria <ravi.bangoria@...ux.ibm.com>,
        Namhyung Kim <namhyung@...nel.org>
Subject: Re: [PATCH v3 0/7] perf/probe: Support multiprobe and immediates
 with fixes

Em Tue, Nov 19, 2019 at 10:46:04PM +0900, Masami Hiramatsu escreveu:
> On Mon, 18 Nov 2019 19:11:04 -0300
> Arnaldo Carvalho de Melo <acme@...nel.org> wrote:
> 
> > Em Mon, Nov 18, 2019 at 05:11:40PM +0900, Masami Hiramatsu escreveu:
> > > Hi Arnaldo,
> > > 
> > > This is the 3rd version of the multiprobe support on perf probe
> > > including some fixes about "representive lines"
> > > 
> > > The previous thread is here:
> > > 
> > > https://lkml.kernel.org/r/157314406866.4063.16995747442215702109.stgit@devnote2
> > > 
> > > On the previous thread, we discussed some issues about incorrect line
> > > information shown by perf probe. I finally fixed those by introducing
> > > an idea of "representive line" -- a line which has a unique address
> > > (no other lines shares the same address) or a line which has the least
> > > line number among lines sharing same address. Now perf probe only shows
> > > such representive lines can be probed([1/7][3/7]), and if user tries to
> > > probe other non representive lines, it shows which line user should
> > > probe ([2/7]). The rest of patches in the series are same as v2 (except
> > > for [4/7], example output is updated)
> > > 
> > > This can be applied on top of perf/core.
> > 
> > Thanks, applied everything, only the two last patches I didn't test, the
> > kernel in this machine doesn't have the features it needs, we can fix
> > things if some problem lurks there.
> 
> Thank you Arnaldo! OK, if anything happens, I'll fix it soon.

np, Ingo already merged it, fast one, soon he'll push his tip/perf/core
branch out, thanks!

- Arnaldo