linux-kernel - Re: [PATCH v5 5/5] arm64: defconfig: enable CONFIG_ARM_QCOM_CPUFREQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 19 Nov 2019 15:45:18 +0100
From:   Niklas Cassel <niklas.cassel@...aro.org>
To:     Stanimir Varbanov <stanimir.varbanov@...aro.org>
Cc:     linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        amit.kucheria@...aro.org, sboyd@...nel.org, vireshk@...nel.org,
        bjorn.andersson@...aro.org, ulf.hansson@...aro.org,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v5 5/5] arm64: defconfig: enable
 CONFIG_ARM_QCOM_CPUFREQ_NVMEM

On Fri, Nov 15, 2019 at 02:44:03PM +0200, Stanimir Varbanov wrote:
> Hi Niklas,
> 
> On 11/15/19 2:15 PM, Niklas Cassel wrote:
> > Enable CONFIG_ARM_QCOM_CPUFREQ_NVMEM.
> 
> Shouldn't this be selected from qcom-cpr.c Kconfig ?

Hello Stan,

I can see where this is coming from.

If e.g. CONFIG_ARM_QCOM_CPUFREQ_NVMEM is selected but
CONFIG_QCOM_CPR is not, then the cpufreq driver will
return -EPROBE_DEFER, and will never probe successfully.

However, I don't really see a difference to any other
driver using a framework that the user has not enabled.
The driver will then use that framework's stubs, which
usually only return -ENODEV or similar.

So even though these both need to be enabled to work as
intended, they can be compiled/build tested separately.


Kind regards,
Niklas

> 
> > 
> > Signed-off-by: Niklas Cassel <niklas.cassel@...aro.org>
> > ---
> >  arch/arm64/configs/defconfig | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> > index 4385033c0a34..09aaffd473a0 100644
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -88,6 +88,7 @@ CONFIG_ACPI_CPPC_CPUFREQ=m
> >  CONFIG_ARM_ARMADA_37XX_CPUFREQ=y
> >  CONFIG_ARM_SCPI_CPUFREQ=y
> >  CONFIG_ARM_IMX_CPUFREQ_DT=m
> > +CONFIG_ARM_QCOM_CPUFREQ_NVMEM=y
> >  CONFIG_ARM_QCOM_CPUFREQ_HW=y
> >  CONFIG_ARM_RASPBERRYPI_CPUFREQ=m
> >  CONFIG_ARM_TEGRA186_CPUFREQ=y
> > 
> 
> -- 
> regards,
> Stan