linux-kernel - Re: [PATCH 3.16 58/87] cifs: add spinlock for the openFileList to cifsInodeInfo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c6b2760910e576af7e40e6b9da47eb81b1cdae68.camel@decadent.org.uk>
Date:   Tue, 19 Nov 2019 14:49:46 +0000
From:   Ben Hutchings <ben@...adent.org.uk>
To:     Pavel Shilovskiy <pshilov@...rosoft.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>
Cc:     "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        Denis Kirjanov <kda@...ux-powerpc.org>,
        Ronnie Sahlberg <lsahlber@...hat.com>,
        Steven French <Steven.French@...rosoft.com>
Subject: Re: [PATCH 3.16 58/87] cifs: add spinlock for the openFileList to
 cifsInodeInfo

On Tue, 2019-10-29 at 14:15 +0100, Ben Hutchings wrote:
> On Mon, 2019-10-28 at 22:19 +0000, Pavel Shilovskiy wrote:
> > > -----Original Message-----
> > > From: Ben Hutchings <ben@...adent.org.uk>
> > > Sent: Wednesday, October 2, 2019 12:07 PM
> > > To: linux-kernel@...r.kernel.org; stable@...r.kernel.org
> > > Cc: akpm@...ux-foundation.org; Denis Kirjanov <kda@...ux-powerpc.org>; Ronnie Sahlberg <lsahlber@...hat.com>; Steven French <Steven.French@...rosoft.com>; Pavel Shilovskiy <pshilov@...rosoft.com>
> > > Subject: [PATCH 3.16 58/87] cifs: add spinlock for the openFileList to cifsInodeInfo
> > > 
> > > 3.16.75-rc1 review patch.  If anyone has any objections, please let me know.
> > > 
> > > ------------------
> > > 
> > > From: Ronnie Sahlberg <lsahlber@...hat.com>
> > > 
> > > commit 487317c99477d00f22370625d53be3239febabbe upstream.
> [...]
> > We have recently found regressions in this patch that are addressed in the following two patches:
> > 
> > cb248819d209d ("cifs: use cifsInodeInfo->open_file_lock while iterating to avoid a panic")
> > 1a67c41596575 ("CIFS: Fix use after free of file info structures")
> > 
> > So, I would suggest either to apply those two patches above or to revert this one.
> 
> Thanks for pointing thse out.  I will try to include those in a later
> update.

I've now queued these up.

Ben.

-- 
Ben Hutchings
Theory and practice are closer in theory than in practice - John Levine



Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)