linux-kernel - Re: [PATCH 04/12] crypto: caam

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <VI1PR0402MB3485A8C1320F32659B95776B984C0@VI1PR0402MB3485.eurprd04.prod.outlook.com>
Date:   Tue, 19 Nov 2019 15:05:12 +0000
From:   Horia Geanta <horia.geanta@....com>
To:     Iuliana Prodan <iuliana.prodan@....com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Aymen Sghaier <aymen.sghaier@....com>
CC:     "David S. Miller" <davem@...emloft.net>,
        Tom Lendacky <thomas.lendacky@....com>,
        Gary Hook <gary.hook@....com>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>
Subject: Re: [PATCH 04/12] crypto: caam - refactor ahash_edesc_alloc

On 11/18/2019 12:31 AM, Iuliana Prodan wrote:
> Changed parameters for ahash_edesc_alloc function:
> - remove flags since they can be computed in
> ahash_edesc_alloc, the only place they are needed;
> - use ahash_request instead of caam_hash_ctx, which
> can be obtained from request.
> 
Technically, the use of ahash_request is to allow for access to
request flags. The change is needed only to be able to refactor
the computation of gfp flags.

> Signed-off-by: Iuliana Prodan <iuliana.prodan@....com>
Reviewed-by: Horia Geantă <horia.geanta@....com>

Thanks,
Horia