linux-kernel - Re: [PATCH v2] arm64: dts: qcom: msm8998-mtp: Add alias for blsp1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOCk7NrvmVFu5PgQsaDJO69kpMAzWdV9DCiGrtQyQRFf6xX5Nw@mail.gmail.com>
Date:   Tue, 19 Nov 2019 08:37:58 -0700
From:   Jeffrey Hugo <jeffrey.l.hugo@...il.com>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:     Andy Gross <agross@...nel.org>,
        MSM <linux-arm-msm@...r.kernel.org>,
        DTML <devicetree@...r.kernel.org>,
        lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] arm64: dts: qcom: msm8998-mtp: Add alias for blsp1_uart3

On Mon, Nov 18, 2019 at 6:18 PM Bjorn Andersson
<bjorn.andersson@...aro.org> wrote:
>
> The msm_serial driver has a predefined set of uart ports defined, which
> is allocated either by reading aliases or if no match is found a simple
> counter, starting at index 0. But there's no logic in place to prevent
> these two allocation mechanism from colliding. As a result either none
> or all of the active msm_serial instances must be listed as aliases.
>
> Define blsp1_uart3 as "serial1" to mitigate this problem.
>
> Fixes: 4cffb9f2c700 ("arm64: dts: qcom: msm8998-mtp: Enable bluetooth")
> Signed-off-by: Bjorn Andersson <bjorn.andersson@...aro.org>

Seems good to me.

Reviewed-by: Jeffrey Hugo <jeffrey.l.hugo@...il.com>

> ---
>
> Changes since v1:
> - Rewrote commit message
>
>  arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi b/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi
> index 5f101a20a20a..e08fcb426bbf 100644
> --- a/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi
> @@ -9,6 +9,7 @@
>  / {
>         aliases {
>                 serial0 = &blsp2_uart1;
> +               serial1 = &blsp1_uart3;
>         };
>
>         chosen {
> --
> 2.23.0
>