linux-kernel - Re: [PATCH V3 0/4] clk: imx: imx8m[x]: switch to clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <VI1PR04MB702313D66C0C6212FDCD9AF5EE4C0@VI1PR04MB7023.eurprd04.prod.outlook.com>
Date:   Tue, 19 Nov 2019 16:45:11 +0000
From:   Leonard Crestez <leonard.crestez@....com>
To:     Peng Fan <peng.fan@....com>, "sboyd@...nel.org" <sboyd@...nel.org>,
        Abel Vesa <abel.vesa@....com>
CC:     "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        dl-linux-imx <linux-imx@....com>,
        Anson Huang <anson.huang@....com>,
        Jacky Bai <ping.bai@....com>,
        "linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Alice Guo <alice.guo@....com>
Subject: Re: [PATCH V3 0/4] clk: imx: imx8m[x]: switch to clk_hw API

On 2019-11-19 11:04 AM, Peng Fan wrote:
> From: Peng Fan <peng.fan@....com>
> 
> V3:
>   Rebased to linux-next to avoid conflict, not based on shawn's clk/imx
>   correct a few pll of imx8mn to imx_pll1443x_pll per Leonard's comments
>   add Abel's R-b tag
> 
> V2:
>   Add a new patch patch 1/4 to avoid build warning for arm64
>   clk: imx: Remove __init for imx_obtain_fixed_clk_hw() API
>   https://patchwork.kernel.org/cover/11224933/
> 
> This patchset is to Switch i.MX8MN/M/Q clk driver to clk_hw
> based API.
> 
> Based on linux-next branch, with [1] applied.
> 
> [1]  clk: imx: switch to clk_hw based API
>       https://patchwork.kernel.org/cover/11217881/

For imx6/7 the big clks array was renamed to "hws" during the switch, 
maybe do this here as well as for consistency? Several non-imx drivers 
use the "hws" name as well.

It would be nice to avoid another patch in the future that rewrites most 
of the file, that kind of stuff makes it difficult to read history.

> Peng Fan (4):
>    clk: imx: Remove __init for imx_obtain_fixed_clk_hw() API
>    clk: imx: imx8mn: Switch to clk_hw based API
>    clk: imx: imx8mm: Switch to clk_hw based API
>    clk: imx: imx8mq: Switch to clk_hw based API
> 
>   drivers/clk/imx/clk-imx8mm.c | 550 +++++++++++++++++++++--------------------
>   drivers/clk/imx/clk-imx8mn.c | 475 ++++++++++++++++++------------------
>   drivers/clk/imx/clk-imx8mq.c | 569 ++++++++++++++++++++++---------------------
>   drivers/clk/imx/clk.c        |   4 +-
>   4 files changed, 819 insertions(+), 779 deletions(-)
>