linux-kernel - Re: USB devices on Dell TB16 dock stop working after resuming

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f0257624-920e-eec4-a2ec-7adf8ecbcc9d@molgen.mpg.de>
Date:   Tue, 19 Nov 2019 17:55:43 +0100
From:   Paul Menzel <pmenzel@...gen.mpg.de>
To:     Mika Westerberg <mika.westerberg@...ux.intel.com>
Cc:     Mario Limonciello <mario.limonciello@...l.com>,
        Andreas Noever <andreas.noever@...il.com>,
        Michael Jamet <michael.jamet@...el.com>,
        Yehezkel Bernat <YehezkelShB@...il.com>,
        Christian Kellner <ck@...om.net>, linux-kernel@...r.kernel.org,
        Anthony Wong <anthony.wong@...onical.com>
Subject: Re: USB devices on Dell TB16 dock stop working after resuming

Dear Mika,


On 2019-11-04 17:21, Mika Westerberg wrote:
> On Mon, Nov 04, 2019 at 05:11:10PM +0100, Paul Menzel wrote:

>> On 2019-11-04 16:49, Mario.Limonciello@...l.com wrote:
>>
>>>> From: Mika Westerberg <mika.westerberg@...ux.intel.com>
>>>> Sent: Monday, November 4, 2019 9:45 AM
>>
>>>> On Mon, Nov 04, 2019 at 04:44:40PM +0200, Mika Westerberg wrote:
>>>>> On Mon, Nov 04, 2019 at 04:25:03PM +0200, Mika Westerberg wrote:
>>
>>>>>> On Mon, Nov 04, 2019 at 02:13:13PM +0100, Paul Menzel wrote:
>>
>>>>>>> On the Dell XPS 13 9380 with Debian Sid/unstable with Linux 5.3.7
>>>>>>> suspending the system, and resuming with Dell’s Thunderbolt TB16
>>>>>>> dock connected, the USB input devices, keyboard and mouse,
>>>>>>> connected to the TB16 stop working. They work for a few seconds
>>>>>>> (mouse cursor can be moved), but then stop working. The laptop
>>>>>>> keyboard and touchpad still works fine. All firmware is up-to-date
>>>>>>> according to `fwupdmgr`.
>>>>>>
>>>>>> What are the exact steps to reproduce? Just "echo mem >
>>>>>> /sys/power/state" and then resume by pressing power button?
>>
>> GNOME Shell 3.34.1+git20191024-1 is used, and the user just closes the
>> display. So more than `echo mem > /sys/power/state` is done. What
>> distribution do you use?
> 
> I have buildroot based "distro" so there is no UI running.

Hmm, this is quite different from the “normal” use-case of the these devices.
That way you won’t hit the bugs of the normal users. ;-)

>>>>> I tried v5.4-rc6 on my 9380 with TB16 dock connected and did a couple of
>>>>> suspend/resume cycles (to s2idle) but I don't see any issues.
>>>>>
>>>>> I may have older/different firmware than you, though.
>>>>
>>>> Upgraded BIOS to 1.8.0 and TBT NVM to v44 but still can't reproduce this
>>>> on my system :/
>>
>> The user reported the issue with the previous firmwares 1.x and TBT NVM v40.
>> Updating to the recent version (I got the logs with) did not fix the issue.
> 
> I also tried v40 (that was originally on that system) but I was not able
> to reproduce it.
> 
> Do you know if the user changed any BIOS settings?

We had to disable the Thunderbolt security settings as otherwise the USB
devices wouldn’t work at cold boot either.

So, I built Linux 5.4-rc8 (`make bindeb-pkg -j8`), but unfortunately the
error is still there. Sometimes, re-plugging the dock helped, and sometimes
it did not.

Please find the logs attached. The strange thing is, the Linux kernel detects
the devices and I do not see any disconnect events. But, `lsusb` does not list
the keyboard and the mouse. Is that expected.

Additionally, despite `CONFIG_PCI_DEBUG` I do not see more elaborate messages.

Lastly, could the daemon boltd have anything to do with this?

```
$ boltctl --version
bolt 0.8
$ boltctl list
 ● Dell Thunderbolt Cable
   ├─ type:          peripheral
   ├─ name:          Dell Thunderbolt Cable
   ├─ vendor:        Dell
   ├─ uuid:          0082b09d-2f5f-d400-ffff-ffffffffffff
   ├─ status:        authorized
   │  ├─ domain:     ca030000-0090-8708-2328-211e02222a24
   │  └─ authflags:  none
   ├─ authorized:    Tue 19 Nov 2019 11:35:11 AM UTC
   ├─ connected:     Tue 19 Nov 2019 11:35:11 AM UTC
   └─ stored:        Fri 13 Sep 2019 01:00:25 PM UTC
      ├─ policy:     auto
      └─ key:        no

 ● Dell Thunderbolt Dock
   ├─ type:          peripheral
   ├─ name:          Dell Thunderbolt Dock
   ├─ vendor:        Dell
   ├─ uuid:          10d34968-1d46-8680-ffff-ffffffffffff
   ├─ status:        authorized
   │  ├─ domain:     ca030000-0090-8708-2328-211e02222a24
   │  └─ authflags:  none
   ├─ authorized:    Tue 19 Nov 2019 11:35:11 AM UTC
   ├─ connected:     Tue 19 Nov 2019 11:35:11 AM UTC
   └─ stored:        Fri 13 Sep 2019 01:01:02 PM UTC
      ├─ policy:     auto
      └─ key:        no

```


Kind regards,

Paul



PS: Suspending the device with the dock attached, and unplugging the dock the
power button LED lights up, but the screen stays black and the device needs
to be forcefully powered off by pressing the power button for 12(?) seconds.



Download attachment "smime.p7s" of type "application/pkcs7-signature" (5174 bytes)