linux-kernel - Re: [PATCH] NCR5380: Unconditionally clear ICR after do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yq1wobwiieo.fsf@oracle.com>
Date:   Mon, 18 Nov 2019 23:45:03 -0500
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Finn Thain <fthain@...egraphics.com.au>
Cc:     "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        "Michael Schmitz" <schmitzmic@...il.com>,
        "Ondrej Zary" <linux@...y.sk>, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] NCR5380: Unconditionally clear ICR after do_abort()


Finn,

> When do_abort() succeeds, the target will go to BUS FREE phase and
> there will be no connected command. Therefore, that function should
> clear the Initiator Command Register before returning. It already does
> so in case of NCR5380_poll_politely() failure; do the same for the
> other error case too, that is, NCR5380_transfer_pio() failure.

Applied to 5.5/scsi-queue, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering