linux-kernel - Re: [PATCH] scsi: lpfc: Move work items to a stack list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4a1fedc9-03f1-7312-fd50-a041a78c0294@broadcom.com>
Date:   Tue, 19 Nov 2019 09:25:54 -0800
From:   James Smart <james.smart@...adcom.com>
To:     Daniel Wagner <dwagner@...e.de>,
        "Martin K. Petersen" <martin.petersen@...cle.com>
Cc:     Dick Kennedy <dick.kennedy@...adcom.com>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        James Smart <james.smart@...adcom.com>
Subject: Re: [PATCH] scsi: lpfc: Move work items to a stack list



On 11/19/2019 5:28 AM, Daniel Wagner wrote:
> On Tue, Nov 12, 2019 at 10:15:00PM -0500, Martin K. Petersen wrote:
>>> While trying to understand what's going on in the Oops below I figured
>>> that it could be the result of the invalid pointer access. The patch
>>> still needs testing by our customer but indepent of this I think the
>>> patch fixes a real bug.
> I was able to reproduce the same stack trace with this patch
> applied... That is obviously bad. The good news, I have access to this
> machine, so maybe I able to figure out what's the root cause of this
> crash.

fyi - Dick and I were taking our time reviewing your patch as the major 
concern we had with it was that the splice and then the re-add of the 
work-list could have an abort complete before the IO, which could lead 
to DC.

We'll look anew at your repro.

-- james