linux-kernel - Re: [PATCH v2 4/4] dt-bindings: mfd: update TI tps6105x chip bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b2ea6130-cfce-4d41-0b35-ba076f599402@gmail.com>
Date:   Tue, 19 Nov 2019 20:38:52 +0100
From:   Jacek Anaszewski <jacek.anaszewski@...il.com>
To:     Sven Van Asbroeck <thesven73@...il.com>,
        Dan Murphy <dmurphy@...com>
Cc:     Lee Jones <lee.jones@...aro.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>, Pavel Machek <pavel@....cz>,
        Rob Herring <robh+dt@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Grigoryev Denis <grigoryev@...twel.ru>,
        Axel Lin <axel.lin@...ics.com>,
        Mark Rutland <mark.rutland@....com>,
        devicetree <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-leds@...r.kernel.org
Subject: Re: [PATCH v2 4/4] dt-bindings: mfd: update TI tps6105x chip bindings

Hi Sven,

On 11/19/19 8:03 PM, Sven Van Asbroeck wrote:
> On Tue, Nov 19, 2019 at 1:37 PM Dan Murphy <dmurphy@...com> wrote:
>>
>>> +
>>> +Example (GPIO + led operation):
>> What part of the example is GPIO? Is that the default function?
> 
> The gpio function is always available by default.
> The mfd driver always adds the gpio mfd_cell.
> But no-one has ever implemented a mfd sub-driver for gpio.
> 
>>> +
>>> +i2c0 {
>>> +     tps61052@33 {
>>> +             compatible = "ti,tps61052";
>>> +             reg = <0x33>;
>>> +
>>> +             led {
>>> +                     label = "tps-torch";
>>
>> function and color examples?
> 
> No function, no colour. This is a simple led control with 8 intensity
> steps. We use it as a led torch on an industrial device.

label DT property was recently deprecated. We now encourage using
'function' and/or 'color'. Please refer to
Documentation/devicetree/bindings/leds/common.txt.

-- 
Best regards,
Jacek Anaszewski