linux-kernel - Re: [PATCH v2 3/4] leds: tps6105x: add driver for mfd chip led mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 19 Nov 2019 16:52:29 -0500
From:   Sven Van Asbroeck <thesven73@...il.com>
To:     Dan Murphy <dmurphy@...com>
Cc:     Lee Jones <lee.jones@...aro.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jacek Anaszewski <jacek.anaszewski@...il.com>,
        Pavel Machek <pavel@....cz>, Rob Herring <robh+dt@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Grigoryev Denis <grigoryev@...twel.ru>,
        Axel Lin <axel.lin@...ics.com>,
        Mark Rutland <mark.rutland@....com>,
        devicetree <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-leds@...r.kernel.org
Subject: Re: [PATCH v2 3/4] leds: tps6105x: add driver for mfd chip led mode

Dan / Jacek,

On Tue, Nov 19, 2019 at 1:33 PM Dan Murphy <dmurphy@...com> wrote:
>
> Prefer device_* calls as opposed to of_* calls.

Ok, I see now how this is done on lp8860 and lm3692x.

So for this led driver to be correct, it should:
- use device_* calls
- use led_init_data (i.e. devm_led_classdev_register_ext)
- drop pdata support for the led subdriver (nice to have)

Unfortunately I can't, because the required infrastructure isn't present in
the 4.19 vendor kernel I'm using.

I only have a single tps6105x chip in my target system, so I don't have
a requirement for devicetree led naming.

So for v3 I will hard-code the led name to 'tps6105x::torch' which should
comply with the naming convention.