linux-kernel - Re: [PATCH v2 15/18] firmware: qcom_scm-32: Add device argument to atomic calls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5dd46921.1c69fb81.aef4b.686e@mx.google.com>
Date:   Tue, 19 Nov 2019 14:13:52 -0800
From:   Stephen Boyd <swboyd@...omium.org>
To:     Elliot Berman <eberman@...eaurora.org>, agross@...nel.org,
        bjorn.andersson@...aro.org, saiprakash.ranjan@...eaurora.org
Cc:     Elliot Berman <eberman@...eaurora.org>, tsoni@...eaurora.org,
        sidgup@...eaurora.org, psodagud@...eaurora.org,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 15/18] firmware: qcom_scm-32: Add device argument to atomic calls

Quoting Elliot Berman (2019-11-12 13:22:51)
> Add this unused parameter to reduce merge friction between SMCCC and
> legacy based conventions.

in an upcoming patch.

> 
> Signed-off-by: Elliot Berman <eberman@...eaurora.org>
> ---
>  drivers/firmware/qcom_scm-32.c | 17 +++++++++--------
>  drivers/firmware/qcom_scm-64.c |  5 +++--
>  drivers/firmware/qcom_scm.c    |  5 +++--
>  drivers/firmware/qcom_scm.h    |  5 +++--
>  4 files changed, 18 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/firmware/qcom_scm-32.c b/drivers/firmware/qcom_scm-32.c
> index eca18e1..c1c0831 100644
> --- a/drivers/firmware/qcom_scm-32.c
> +++ b/drivers/firmware/qcom_scm-32.c
> @@ -269,7 +269,7 @@ static int qcom_scm_call(struct device *dev, struct qcom_scm_desc *desc)
>   * This shall only be used with commands that are guaranteed to be
>   * uninterruptable, atomic and SMP safe.
>   */
> -static int qcom_scm_call_atomic(struct qcom_scm_desc *desc)
> +static int qcom_scm_call_atomic(struct device *dev, struct qcom_scm_desc *desc)

If the argument is unused, how about call it 'struct device *unused' so
we can ignore it?

>  {
>         int context_id;
>         struct arm_smccc_args smc = {0};